From: Stefano Babic <stefano.babic@babic.homelinux.org>
To: sjur.brandeland@stericsson.com
Cc: netdev@vger.kernel.org, Kim.xx.Lilliestierna@ericsson.com
Subject: Re: [1/8,RFC] CAIF Protocol Stack
Date: Mon, 05 Oct 2009 14:55:48 +0200 [thread overview]
Message-ID: <4AC9ECD4.70602@babic.homelinux.org> (raw)
In-Reply-To: <1253727026-10233-1-git-send-email-sjur.brandeland@stericsson.com>
sjur.brandeland@stericsson.com wrote:
> diff --git a/include/linux/caif/caif_ioctl.h b/include/linux/caif/caif_ioctl.h
> new file mode 100644
> index 0000000..4fdd648
> --- /dev/null
> +++ b/include/linux/caif/caif_ioctl.h
[snip]
> +/**
> + * union caif_action
> + * This union is used to configure a new CAIF Channel and
> + */
> +
> +union caif_action {
> + struct caif_device_name delete_channel;
> + struct caif_channel_create_action create_channel;
> +};
It seems this structure is defined twice (here and in caif_actions.h)
and some modules (at least phyif_ser, I could check) are not compiled
clean, because both header files are included. Maybe should be protected
with ifndef __KERNEL__ ?
Regards,
Stefano
--
stefano <stefano.babic@babic.homelinux.org>
GPG Key: 0x55814DDE
Fingerprint 4E85 2A66 4CBA 497A 2A7B D3BF 5973 F216 5581 4DDE
next prev parent reply other threads:[~2009-10-05 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 17:30 [PATCH 1/8] [RFC] CAIF Protocol Stack sjur.brandeland
2009-10-05 12:55 ` Stefano Babic [this message]
2009-10-06 19:00 ` [1/8,RFC] " Sjur Brændeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC9ECD4.70602@babic.homelinux.org \
--to=stefano.babic@babic.homelinux.org \
--cc=Kim.xx.Lilliestierna@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=sjur.brandeland@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox