Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ramkrishna Vepa <Ramkrishna.Vepa@neterion.com>
Cc: David Miller <davem@davemloft.net>,
	Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com>,
	netdev@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH 8/9] vxge: Acquire correct lock based on interrupt context.
Date: Tue, 06 Oct 2009 05:19:06 +0200	[thread overview]
Message-ID: <4ACAB72A.3080802@gmail.com> (raw)
In-Reply-To: <78C9135A3D2ECE4B8162EBDCE82CAD7705C16322@nekter>

Ramkrishna Vepa a écrit :
> [Ram] Right, but why have the additional step of saving and restoring
> the flags while in the interrupt context?
> 

It costs about the same thing than testing two times in_interrupt()

pushf
pop register
test iflag,register
je ...


In the end, original code is shorter and faster.

  reply	other threads:[~2009-10-06  3:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-05 11:58 [net-next-2.6 PATCH 8/9] vxge: Acquire correct lock based on interrupt context Sreenivasa Honnur
2009-10-05 12:37 ` David Miller
2009-10-06  2:36   ` Ramkrishna Vepa
2009-10-06  3:19     ` Eric Dumazet [this message]
2009-10-06  3:23       ` Ramkrishna Vepa
2009-10-06  4:18     ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2009-10-05  9:14 Sreenivasa Honnur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACAB72A.3080802@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=Ramkrishna.Vepa@neterion.com \
    --cc=Sreenivasa.Honnur@neterion.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox