netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Gilad Ben-Yossef <gilad@codefidence.com>
Cc: netdev@vger.kernel.org, Ori Finkelman <ori@comsleep.com>,
	Andreas Henriksson <andreas@fatal.se>,
	Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH] iproute2 add hoplimit parsing and update usage and documentation
Date: Tue, 06 Oct 2009 19:14:28 +0200	[thread overview]
Message-ID: <4ACB7AF4.4070207@gmail.com> (raw)
In-Reply-To: <1254836434.544524.27946.nullmailer@watson.codefidence.com>

Gilad Ben-Yossef a écrit :
> From: Gilad Ben-Yossef <gilad@codefidence.com>
> 
> - Parse and handle the hoplimit ip route option and add it to the usage 
>   line and documentation.
> 
> - Add the missing reordering ip route option to the usage line.
> 
> - Add documentation for initcwnd ip route option.
> 
> Tested by setting hoplimit and retreiving it via "show". 
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@codefidence.com>
> [ported to HEAD, fixed a bug with hoplimit lock handling, added documentation]
> Signed-off-by: Ori Finkelman <ori@comsleep.com>
> Signed-off-by: Yony Amit <yony@comsleep.com>
> 

> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -13,6 +13,8 @@
>   *
>   * Rani Assaf <rani@magic.metawire.com> 980929:	resolve addresses
>   * Kunihiro Ishiguro <kunihiro@zebra.org> 001102: rtnh_ifindex was not initialized
> + * Gilad Ben-Yossef <gilad@codefidence.com> 091006: Add hoplimit option parsing 
> + * and correct usage

Well, git/web history is much better than this, you dont need to add this comment.

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>

patch should be sent to iproute2 maintainer, Stephen Hemminger <shemminger@vyatta.com>

He might be too busy to catch netdev mails these days, I dont know :)

Thanks

  reply	other threads:[~2009-10-06 17:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-05  8:54 [PATCH] iproute2 add hoplimit and reordering route options usage and parsing Gilad Ben-Yossef
2009-10-06 11:41 ` Andreas Henriksson
2009-10-06 12:37   ` Gilad Ben-Yossef
2009-10-06 13:40     ` [PATCH] iproute2 add hoplimit parsing and update usage and documentation Gilad Ben-Yossef
2009-10-06 17:14       ` Eric Dumazet [this message]
2009-10-06 17:34         ` Stephen Hemminger
2009-12-01 23:53       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACB7AF4.4070207@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=andreas@fatal.se \
    --cc=gilad@codefidence.com \
    --cc=netdev@vger.kernel.org \
    --cc=ori@comsleep.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).