* [PATCH] sb1250-mac: duplicate setting of bit V_MAC_RX_PL_THRSH(4) in sbmac_channel_start()
@ 2009-10-06 20:07 Roel Kluin
2009-10-13 10:48 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-10-06 20:07 UTC (permalink / raw)
To: netdev, davem, Andrew Morton
The bit V_MAC_RX_PL_THRSH(4) was already set a few lines higher.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Please review. Maybe it should be replaced by something else?
diff --git a/drivers/net/sb1250-mac.c b/drivers/net/sb1250-mac.c
index 508551f..7269a87 100644
--- a/drivers/net/sb1250-mac.c
+++ b/drivers/net/sb1250-mac.c
@@ -1476,7 +1476,6 @@ static void sbmac_channel_start(struct sbmac_softc *s)
V_MAC_TX_RL_THRSH(4) |
V_MAC_RX_PL_THRSH(4) |
V_MAC_RX_RD_THRSH(4) | /* Must be '4' */
- V_MAC_RX_PL_THRSH(4) |
V_MAC_RX_RL_THRSH(8) |
0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sb1250-mac: duplicate setting of bit V_MAC_RX_PL_THRSH(4) in sbmac_channel_start()
2009-10-06 20:07 [PATCH] sb1250-mac: duplicate setting of bit V_MAC_RX_PL_THRSH(4) in sbmac_channel_start() Roel Kluin
@ 2009-10-13 10:48 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-10-13 10:48 UTC (permalink / raw)
To: roel.kluin; +Cc: netdev, akpm
From: Roel Kluin <roel.kluin@gmail.com>
Date: Tue, 06 Oct 2009 22:07:15 +0200
> The bit V_MAC_RX_PL_THRSH(4) was already set a few lines higher.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Please review. Maybe it should be replaced by something else?
Maybe, but or'ing it in twice is definitely pointless.
Applied to net-next-2.6, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-13 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-06 20:07 [PATCH] sb1250-mac: duplicate setting of bit V_MAC_RX_PL_THRSH(4) in sbmac_channel_start() Roel Kluin
2009-10-13 10:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).