* [PATCH] IPv6: Fix 6RD build error
@ 2009-10-07 15:01 Brian Haley
2009-10-07 20:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Brian Haley @ 2009-10-07 15:01 UTC (permalink / raw)
To: David Miller, YOSHIFUJI Hideaki; +Cc: netdev@vger.kernel.org
Fix build error introduced in commit fa857afcf - ipv6 sit: 6rd
(IPv6 Rapid Deployment) Support. Struct in6_addr is the issue.
I'm only seeing this on x86_64 systems, not on 32-bit with same
IPv6 config options, so it could be there's a missing forward
declaration somewhere, but including the correct header file
fixes the problem too.
CC [M] net/ipv6/ip6_tunnel.o
In file included from net/ipv6/ip6_tunnel.c:31:
include/linux/if_tunnel.h:59: error: field ‘prefix’ has incomplete type
make[2]: *** [net/ipv6/ip6_tunnel.o] Error 1
make[1]: *** [net/ipv6] Error 2
Signed-off-by: Brian Haley <brian.haley@hp.com>
---
diff --git a/include/linux/if_tunnel.h b/include/linux/if_tunnel.h
index c53c8e0..8d76cb4 100644
--- a/include/linux/if_tunnel.h
+++ b/include/linux/if_tunnel.h
@@ -5,6 +5,7 @@
#ifdef __KERNEL__
#include <linux/ip.h>
+#include <linux/in6.h>
#endif
#define SIOCGETTUNNEL (SIOCDEVPRIVATE + 0)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] IPv6: Fix 6RD build error
2009-10-07 15:01 [PATCH] IPv6: Fix 6RD build error Brian Haley
@ 2009-10-07 20:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-10-07 20:57 UTC (permalink / raw)
To: brian.haley; +Cc: yoshfuji, netdev
From: Brian Haley <brian.haley@hp.com>
Date: Wed, 07 Oct 2009 11:01:26 -0400
> Fix build error introduced in commit fa857afcf - ipv6 sit: 6rd
> (IPv6 Rapid Deployment) Support. Struct in6_addr is the issue.
> I'm only seeing this on x86_64 systems, not on 32-bit with same
> IPv6 config options, so it could be there's a missing forward
> declaration somewhere, but including the correct header file
> fixes the problem too.
>
> CC [M] net/ipv6/ip6_tunnel.o
> In file included from net/ipv6/ip6_tunnel.c:31:
> include/linux/if_tunnel.h:59: error: field ‘prefix’ has incomplete type
> make[2]: *** [net/ipv6/ip6_tunnel.o] Error 1
> make[1]: *** [net/ipv6] Error 2
>
> Signed-off-by: Brian Haley <brian.haley@hp.com>
Funny, I didn't see this on sparc64.
Applied, thanks Brian!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-07 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-07 15:01 [PATCH] IPv6: Fix 6RD build error Brian Haley
2009-10-07 20:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).