* [PATCH] netxen: fix pci bar mapping
@ 2009-10-12 2:43 Dhananjay Phadke
2009-10-12 6:06 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Dhananjay Phadke @ 2009-10-12 2:43 UTC (permalink / raw)
To: davem; +Cc: netdev
Use phys_addr_t data type for pci resource address
instead of unsigned long. This fixes mapping of
pci resources where resource addresses can be larger
than word size (e.g. PAE).
Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>
---
drivers/net/netxen/netxen_nic_main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index 9b9eab1..194b3e3 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -595,7 +595,8 @@ netxen_setup_pci_map(struct netxen_adapter *adapter)
void __iomem *mem_ptr2 = NULL;
void __iomem *db_ptr = NULL;
- unsigned long mem_base, mem_len, db_base, db_len = 0, pci_len0 = 0;
+ phys_addr_t mem_base, db_base;
+ unsigned long mem_len, db_len = 0, pci_len0 = 0;
struct pci_dev *pdev = adapter->pdev;
int pci_func = adapter->ahw.pci_func;
--
1.6.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] netxen: fix pci bar mapping
2009-10-12 2:43 [PATCH] netxen: fix pci bar mapping Dhananjay Phadke
@ 2009-10-12 6:06 ` David Miller
2009-10-12 6:12 ` Dhananjay Phadke
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2009-10-12 6:06 UTC (permalink / raw)
To: dhananjay; +Cc: netdev
From: Dhananjay Phadke <dhananjay@netxen.com>
Date: Sun, 11 Oct 2009 19:43:22 -0700
> Use phys_addr_t data type for pci resource address
> instead of unsigned long. This fixes mapping of
> pci resources where resource addresses can be larger
> than word size (e.g. PAE).
>
> Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>
The correct type to use is 'resource_size_t' not 'phys_addr_t'.
Look at the "struct resource" member types in linux/ioport.h, that's
what these pci_resource_start() et al. routines return.
Please fix this up and resubmit.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] netxen: fix pci bar mapping
2009-10-12 6:06 ` David Miller
@ 2009-10-12 6:12 ` Dhananjay Phadke
0 siblings, 0 replies; 3+ messages in thread
From: Dhananjay Phadke @ 2009-10-12 6:12 UTC (permalink / raw)
To: David Miller; +Cc: netdev@vger.kernel.org
Ok, I am resending the patch.
Thanks,
Dhananjay
David Miller wrote:
> From: Dhananjay Phadke <dhananjay@netxen.com>
> Date: Sun, 11 Oct 2009 19:43:22 -0700
>
>> Use phys_addr_t data type for pci resource address
>> instead of unsigned long. This fixes mapping of
>> pci resources where resource addresses can be larger
>> than word size (e.g. PAE).
>>
>> Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>
>
> The correct type to use is 'resource_size_t' not 'phys_addr_t'.
>
> Look at the "struct resource" member types in linux/ioport.h, that's
> what these pci_resource_start() et al. routines return.
>
> Please fix this up and resubmit.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-12 6:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-12 2:43 [PATCH] netxen: fix pci bar mapping Dhananjay Phadke
2009-10-12 6:06 ` David Miller
2009-10-12 6:12 ` Dhananjay Phadke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).