From: Joyce Yu <Joyce.Yu@Sun.COM>
To: netdev@vger.kernel.org
Subject: [PATCH] [NIU] VLAN does not work with niu driver
Date: Mon, 12 Oct 2009 22:41:36 -0700 [thread overview]
Message-ID: <4AD41310.7040209@Sun.COM> (raw)
From 0bb77e878758bd72051577bcc568e2b95c87c203 Mon Sep 17 00:00:00 2001
From: Joyce Yu <joyce.yu@sun.com>
Date: Mon, 12 Oct 2009 11:03:54 -0700
Subject: [PATCH] VLAN does not work with niu driver
Signed-off-by: Joyce Yu <joyce.yu@sun.com>
---
drivers/net/niu.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/net/niu.c b/drivers/net/niu.c
index f9364d0..9559e42 100644
--- a/drivers/net/niu.c
+++ b/drivers/net/niu.c
@@ -3480,6 +3480,7 @@ static int niu_process_rx_pkt(struct napi_struct
*napi, struct niu *np,
unsigned int index = rp->rcr_index;
struct sk_buff *skb;
int len, num_rcr;
+ struct vlan_ethhdr *veth;
skb = netdev_alloc_skb(np->dev, RX_SKB_ALLOC_SIZE);
if (unlikely(!skb))
@@ -3545,7 +3546,15 @@ static int niu_process_rx_pkt(struct napi_struct
*napi, struct niu *np,
rp->rcr_index = index;
skb_reserve(skb, NET_IP_ALIGN);
- __pskb_pull_tail(skb, min(len, NIU_RXPULL_MAX));
+ __pskb_pull_tail(skb, min(len, VLAN_ETH_HLEN));
+
+ veth = (struct vlan_ethhdr *)skb->data;
+ if (veth->h_vlan_proto != __constant_htons(ETH_P_8021Q)) {
+ skb->tail -= 4;
+ skb->data_len += 4;
+ skb_shinfo(skb)->frags[0].page_offset -= 4;
+ skb_shinfo(skb)->frags[0].size += 4;
+ }
rp->rx_packets++;
rp->rx_bytes += skb->len;
--
1.6.4
--
next reply other threads:[~2009-10-13 5:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 5:41 Joyce Yu [this message]
2009-10-13 6:22 ` [PATCH] [NIU] VLAN does not work with niu driver David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-10-21 18:02 Joyce Yu
2009-10-21 23:09 ` David Miller
2009-10-21 23:28 ` Joyce Yu
2009-10-22 0:19 ` David Miller
2009-10-15 19:16 Joyce Yu
2009-10-13 21:27 Joyce Yu
2009-10-13 22:12 ` David Miller
2009-10-20 0:28 ` David Miller
2009-10-12 23:26 Joyce Yu
2009-10-12 23:52 ` David Miller
2009-09-09 21:10 Joyce Yu
2009-09-09 21:35 ` Stephen Hemminger
2009-09-10 0:16 ` David Miller
2009-09-10 0:15 ` David Miller
2009-09-10 1:01 ` Matheos Worku
2009-09-10 1:10 ` David Miller
2009-09-10 1:19 ` Matheos Worku
2009-09-10 1:44 ` David Miller
2009-09-10 1:48 ` Matheos Worku
2009-09-10 16:35 ` Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD41310.7040209@Sun.COM \
--to=joyce.yu@sun.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).