From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] net: Add netdev_alloc_skb_ip_align() helper
Date: Tue, 13 Oct 2009 20:06:15 +0200 [thread overview]
Message-ID: <4AD4C197.40608@gmail.com> (raw)
In-Reply-To: <20091013103037.475e2400@s6510>
Stephen Hemminger a écrit :
> Name_is_getting_too_damn_long can we think of something beter.
yes probably
>
> Also, it isn't really ip alignment but compensating for the ethernet
> header.
> alloc_ether_skb?
Dont know, but NET_IP_ALIGN was about making sure skb->data + sizeof(ethernet header)
is 4 bytes aligned, not for handling ethernet header itself in our stack (we only need
2 bytes alignement for this ethernet header), but IP header.
next prev parent reply other threads:[~2009-10-13 18:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 2:32 [PATCH] ethoc: use NET_IP_ALIGN in skb_reserve() Thomas Chou
2009-10-08 3:11 ` [PATCH] net: Add netdev_alloc_skb_ip_align() helper Eric Dumazet
2009-10-08 4:36 ` Thomas Chou
2009-10-08 5:40 ` David Miller
2009-10-09 16:31 ` Eric Dumazet
2009-10-10 3:43 ` David Miller
2009-10-13 10:45 ` David Miller
2009-10-13 15:34 ` Eric Dumazet
2009-10-13 17:30 ` Stephen Hemminger
2009-10-13 18:06 ` Eric Dumazet [this message]
2009-10-13 18:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD4C197.40608@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).