From: Wolfgang Grandegger <wg@grandegger.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org,
davem@davemloft.net, John Bonesio <bones@secretlab.ca>
Subject: Re: [PATCH v2] net/fec_mpc52xx: Fix kernel panic on FEC error
Date: Wed, 14 Oct 2009 21:11:03 +0200 [thread overview]
Message-ID: <4AD62247.4020102@grandegger.com> (raw)
In-Reply-To: <20091014174224.29221.18830.stgit@angua>
Grant Likely wrote:
> From: John Bonesio <bones@secretlab.ca>
>
> The MDIO bus cannot be accessed at interrupt context, but on an FEC
> error, the fec_mpc52xx driver reset function also tries to reset the
> PHY. Since the error is detected at IRQ context, and the PHY functions
> try to sleep, the kernel ends up panicking.
>
> Resetting the PHY on an FEC error isn't even necessary. This patch
> solves the problem by removing the PHY reset entirely.
There is also no need to free and re-allocate the RX buffers in
mpc52xx_fec_reset().
Wolfgang.
next prev parent reply other threads:[~2009-10-14 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 17:43 [PATCH v2] net/fec_mpc52xx: Fix kernel panic on FEC error Grant Likely
2009-10-14 19:11 ` Wolfgang Grandegger [this message]
2009-10-14 19:32 ` Grant Likely
2009-10-14 22:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD62247.4020102@grandegger.com \
--to=wg@grandegger.com \
--cc=bones@secretlab.ca \
--cc=davem@davemloft.net \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).