netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Massimo Cetra <mcetra@navynet.it>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Massimo Cetra <ctrixk@navynet.it>,
	David Miller <davem@davemloft.net>,
	rjw@sisk.pl, linux-kernel@vger.kernel.org,
	kernel-testers@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [Bug #14378] Problems with net/core/skbuff.c
Date: Wed, 14 Oct 2009 21:27:34 +0200	[thread overview]
Message-ID: <4AD62626.6010709@navynet.it> (raw)
In-Reply-To: <4AD455E4.2070105@navynet.it>

Massimo Cetra ha scritto:
> Eric Dumazet ha scritto:
>> Could you please following patch ?
>>
>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>> index 8d00976..54bf091 100644
>> --- a/drivers/net/virtio_net.c
>> +++ b/drivers/net/virtio_net.c
>> @@ -454,7 +454,7 @@ static unsigned int free_old_xmit_skbs(struct 
>> virtnet_info *vi)
>>          vi->dev->stats.tx_bytes += skb->len;
>>          vi->dev->stats.tx_packets++;
>>          tot_sgs += skb_vnet_hdr(skb)->num_sg;
>> -        kfree_skb(skb);
>> +        dev_kfree_skb_any(skb);
>>      }
>>      return tot_sgs;
>>  }
>>
>>
>>   
> Thank you very much.
>
> Compiling.
> It' will be in production in a few minutes.
> I'll let you know if the problem arises again.
> give me a couple of days because this problem is randomly triggered.
> Sometimes it happens multiple times a day, sometimes none.
>
Eric,
thanks for the patch.
The problem didn't arise again and i haven't seen any warning like that 
on both servers where that problem was happening more frequently.

I would say that it's fixed and if it's not, i'll let you know as soon 
as it happens again.

Thanks again,
Max

  reply	other threads:[~2009-10-14 19:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-11 22:07 2.6.32-rc4: Reported regressions from 2.6.31 Rafael J. Wysocki
     [not found] ` <r-4Wjt4coy.A.TPD.dal0KB@chimera>
     [not found]   ` <b637ec0b0910121148g34f46481n1d5d4edb67b0ac55@mail.gmail.com>
2009-10-12 21:55     ` [Bug #14372] Wireless not working after suspend-resume Rafael J. Wysocki
     [not found] ` <r-4Wjt4coy.A.CwC.Wal0KB@chimera>
     [not found]   ` <20091012.034224.64980795.davem@davemloft.net>
2009-10-13  9:11     ` [Bug #14378] Problems with net/core/skbuff.c Massimo Cetra
2009-10-13  9:23       ` Massimo Cetra
2009-10-13 10:19       ` Eric Dumazet
2009-10-13 10:25         ` David Miller
2009-10-13 10:26         ` Massimo Cetra
2009-10-14 19:27           ` Massimo Cetra [this message]
     [not found]             ` <4AD62626.6010709-BBpJ+9iBSNKonA0d6jMUrA@public.gmane.org>
2009-10-15  0:36               ` [PATCH] virtio_net: use dev_kfree_skb_any() in free_old_xmit_skbs() Eric Dumazet
2009-10-15  6:30                 ` David Miller
     [not found]       ` <4AD44435.3050703-BBpJ+9iBSNKonA0d6jMUrA@public.gmane.org>
2009-10-13 10:22         ` [Bug #14378] Problems with net/core/skbuff.c David Miller
     [not found]           ` <20091013.032237.45775304.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-10-13 10:27             ` Massimo Cetra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD62626.6010709@navynet.it \
    --to=mcetra@navynet.it \
    --cc=ctrixk@navynet.it \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=kernel-testers@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).