netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: deri@ntop.org, shemminger@vyatta.com, brad.doctor@gmail.com,
	netdev@vger.kernel.org
Subject: Re: PF_RING: Include in main line kernel?
Date: Thu, 15 Oct 2009 02:25:33 +0200	[thread overview]
Message-ID: <4AD66BFD.8010100@gmail.com> (raw)
In-Reply-To: <20091014.132756.231458769.davem@davemloft.net>

David Miller a écrit :
> From: Luca Deri <deri@ntop.org>
> Date: Wed, 14 Oct 2009 22:17:30 +0200
> 
>> Another reason, is that having a hook in dev.c, device drivers can
>> pass PF_RING packets directly without going through the standard
>> kernel mechanisms. For instance I have developed some drivers that if
>> they detect the presence of PF_RING, pass received packets directly to
>> PF_RING instead of going with NAPI.
> 
> There is absolutely no reason to do this.
> 
> If the existing infrastructure isn't good or fast enough,
> fix it, don't bypass it.

Indeed. IMHO PF_RING seems a huge pile of hacks to me, that would need
a lot of cleanup work before inclusion.

I had problems with past af_packet mmap implementation on ia32, because
not enough high order pages where available in lowmem.

"tcpdump -s 0" could trigger OOM conditions on loaded machines, not sure
it is still the case after commit 719bfeaae8104fca4ca5d47c02592b08682f14fa
(packet: avoid warnings when high-order page allocation fails)

If mmap() can only use 4K pages, are we still able to capture >4K packets ?

I'll check this.

  reply	other threads:[~2009-10-15  0:26 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-14 14:33 PF_RING: Include in main line kernel? Brad Doctor
2009-10-14 16:01 ` Stephen Hemminger
2009-10-14 17:02   ` Brad Doctor
2009-10-14 19:33     ` Stephen Hemminger
2009-10-14 20:17       ` Luca Deri
2009-10-14 20:27         ` David Miller
2009-10-15  0:25           ` Eric Dumazet [this message]
2009-10-14 20:36         ` Evgeniy Polyakov
2009-10-14 21:27           ` Ben Greear
2009-10-14 21:34             ` Luca Deri
2009-10-14 21:49             ` David Miller
2009-10-14 23:29               ` Ben Greear
2009-10-15  7:02               ` Evgeniy Polyakov
2009-10-15  7:22                 ` David Miller
2009-10-15 16:33                 ` Ben Greear
2009-10-18 12:45                   ` Harald Welte
2009-10-18 12:43               ` Harald Welte
2009-10-18 14:18                 ` Evgeniy Polyakov
2009-10-14 16:46 ` Jarek Poplawski
2009-10-14 17:02   ` Brad Doctor
2009-10-14 17:18     ` Jarek Poplawski
2009-10-18 12:47   ` [OT] ntop / GPL (was Re: PF_RING: Include in main line kernel?) Harald Welte
2009-10-19  5:55     ` Jarek Poplawski
2009-10-19  7:12       ` Jarek Poplawski
2009-10-14 18:19 ` PF_RING: Include in main line kernel? Brent Cook
2009-10-14 19:54   ` Luca Deri
2009-10-14 20:15     ` David Miller
2009-10-14 20:26       ` Luca Deri
2009-10-14 20:29         ` David Miller
2009-10-14 20:34           ` Luca Deri
2009-10-14 20:50             ` Mark Smith
2009-10-18 12:56             ` Harald Welte
2009-10-18 12:50     ` Harald Welte
2009-10-18 14:50       ` Evgeniy Polyakov
2009-10-15  7:35 ` Rémi Denis-Courmont
2009-10-18 12:38 ` Harald Welte
2009-10-18 17:37   ` Luca Deri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD66BFD.8010100@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=brad.doctor@gmail.com \
    --cc=davem@davemloft.net \
    --cc=deri@ntop.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).