From: Eric Dumazet <eric.dumazet@gmail.com>
To: Krishna Kumar2 <krkumar2@in.ibm.com>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [PATCH 2/4 v2] net: Use sk_tx_queue_mapping for connected sockets
Date: Fri, 16 Oct 2009 16:07:30 +0200 [thread overview]
Message-ID: <4AD87E22.9040500@gmail.com> (raw)
In-Reply-To: <OFAE5CC975.C26B600E-ON65257651.00401683-65257651.004721BC@in.ibm.com>
Krishna Kumar2 a écrit :
> I wait for tcp_v4_syn_recv_sock to finish and create a connection.
> sk_setup_caps/__sk_dst_set are called for the new socket resulting
> in sk_dst_cache getting set (I cannot set the cache till the
> connection is finished and dst is set). I guess that means that I
> will wait for another skb to come and the response will use skb_tx_hash
> instead of using the rx recorded.
Well, I see no relation between rx mapping and tx mapping currently.
>
> Will this suffice, but if not, is it something I should handle or an
> add-on patch should do instead?
>
Your patch is fine, I was only giving ideas for future patches :)
next prev parent reply other threads:[~2009-10-16 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 7:21 [PATCH 0/4 v2] net: Implement fast TX queue selection Krishna Kumar
2009-10-16 7:21 ` [PATCH 1/4 v2] net: Introduce sk_tx_queue_mapping Krishna Kumar
2009-10-16 9:57 ` Eric Dumazet
2009-10-16 12:58 ` Krishna Kumar2
2009-10-16 7:21 ` [PATCH 2/4 v2] net: Use sk_tx_queue_mapping for connected sockets Krishna Kumar
2009-10-16 9:48 ` Eric Dumazet
2009-10-16 12:56 ` Krishna Kumar2
2009-10-16 14:07 ` Eric Dumazet [this message]
2009-10-16 15:47 ` Krishna Kumar2
2009-10-16 7:21 ` [PATCH 3/4 v2] net: IPv6 changes Krishna Kumar
2009-10-16 7:22 ` [PATCH 4/4 v2] net: Fix for dst_negative_advice Krishna Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD87E22.9040500@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).