From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Michal Ostrowski <mostrows@gmail.com>,
Denys Fedoryschenko <denys@visp.net.lb>,
netdev <netdev@vger.kernel.org>,
linux-ppp@vger.kernel.org, paulus@samba.org,
mostrows@earthlink.net
Subject: Re: kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces
Date: Tue, 20 Oct 2009 07:05:28 +0200 [thread overview]
Message-ID: <4ADD4518.8020909@gmail.com> (raw)
In-Reply-To: <aa79d98a0910192202j4ea9f189g2ff719d57aa5a5eb@mail.gmail.com>
Cyrill Gorcunov a écrit :
> On 10/20/09, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> Michal Ostrowski a écrit :
>>> Access of po->pppoe_dev is guarded by sk->sk_state & PPPOX_CONNECTED,
>>> and all use cases now rely on the socket lock. Because of this, the
>>> ref-count on the namespace held by the socket object suffices to hold
>>> the namespace in existence and so we don't need to ref-count the
>>> namespace in PPPoE. The flush_lock is gone.
>>>
>> Seems good !
>>
>> But can we use lock_sock() in __pppoe_xmit() context ?
>>
>
> Eric, most probably i miss something, but how lock sock protect us
> from mtu changed via sysfs. This action calls change mtu notifier
> which doesn't care about sockets at all...
This ultimately calls pppoe_flush_dev() and this function
takes care of taking appropriate sock_locks() on each sockets ?
next prev parent reply other threads:[~2009-10-20 5:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 21:02 kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Denys Fedoryschenko
2009-10-19 3:34 ` Michal Ostrowski
2009-10-19 11:36 ` Denys Fedoryschenko
2009-10-19 12:01 ` Denys Fedoryschenko
2009-10-19 12:36 ` Eric Dumazet
2009-10-19 13:19 ` Michal Ostrowski
2009-10-19 15:50 ` Cyrill Gorcunov
2009-10-19 16:05 ` Michal Ostrowski
2009-10-19 17:12 ` Eric Dumazet
2009-10-19 18:07 ` Michal Ostrowski
2009-10-19 18:44 ` Eric Dumazet
2009-10-19 19:29 ` Cyrill Gorcunov
2009-10-19 20:54 ` Michal Ostrowski
2009-10-20 3:42 ` Eric Dumazet
2009-10-20 5:02 ` Cyrill Gorcunov
2009-10-20 5:05 ` Eric Dumazet [this message]
2009-10-20 5:17 ` Cyrill Gorcunov
2009-10-20 6:04 ` Cyrill Gorcunov
2009-10-19 20:57 ` Cyrill Gorcunov
2009-10-19 21:22 ` Michal Ostrowski
2009-10-20 0:08 ` Denys Fedoryschenko
2009-10-20 3:04 ` Cyrill Gorcunov
2009-10-20 11:36 ` Denys Fedoryschenko
2009-10-20 11:50 ` Cyrill Gorcunov
2009-10-20 11:52 ` Denys Fedoryschenko
2009-10-20 13:42 ` Cyrill Gorcunov
2009-10-20 13:50 ` Denys Fedoryschenko
2009-10-20 13:59 ` Cyrill Gorcunov
2009-10-20 14:20 ` Denys Fedoryschenko
2009-10-20 14:23 ` Cyrill Gorcunov
2009-10-20 19:08 ` Cyrill Gorcunov
2009-10-23 15:18 ` Cyrill Gorcunov
2009-10-25 18:10 ` Denys Fedoryschenko
2009-10-20 2:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADD4518.8020909@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=denys@visp.net.lb \
--cc=gorcunov@gmail.com \
--cc=linux-ppp@vger.kernel.org \
--cc=mostrows@earthlink.net \
--cc=mostrows@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).