From: Eric Dumazet <eric.dumazet@gmail.com>
To: Krishna Kumar2 <krkumar2@in.ibm.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: build test your changes!
Date: Tue, 20 Oct 2009 09:36:30 +0200 [thread overview]
Message-ID: <4ADD687E.4040808@gmail.com> (raw)
In-Reply-To: <OF1BCE4CF8.BD48A587-ON65257655.0024B1CD-65257655.0025CC6C@in.ibm.com>
Krishna Kumar2 a écrit :
> Sorry about the build failure. I did do a build and a stress test. But
> I missed changing the name sk_record_tx_queue() in both sock.h
> and dev.c when testing. I caught the miss before sending the patch,
> but changed the name only in sock.h, and didn't do a final build
> again. Sorry about this, will not assume next time.
>
> I will fix this (including patch order) and resend after build and test.
>
Yes please, I am looking for your patches being added before my next round :)
(Specifically, I was waiting sizeof(struct sock_common) goes from 0x38 to 0x40
on 64 bit arches)
prev parent reply other threads:[~2009-10-20 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 6:22 build test your changes! David Miller
2009-10-20 6:52 ` Krishna Kumar2
2009-10-20 7:36 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADD687E.4040808@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).