* build test your changes!
@ 2009-10-20 6:22 David Miller
2009-10-20 6:52 ` Krishna Kumar2
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2009-10-20 6:22 UTC (permalink / raw)
To: krkumar2; +Cc: netdev
Krishna, you add:
+static inline void sk_tx_queue_set(struct sock *sk, int tx_queue)
...
+static inline void sk_tx_queue_clear(struct sock *sk)
...
+static inline int sk_tx_queue_get(const struct sock *sk)
...
+static inline bool sk_tx_queue_recorded(const struct sock *sk)
But then in the net/core/dev.c patch you go:
+ if (sk && sk->sk_dst_cache)
+ sk_record_tx_queue(sk, queue_index);
I cannot see how you did a build test of this, it's absolutely impossible.
I'm reverting.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: build test your changes!
2009-10-20 6:22 build test your changes! David Miller
@ 2009-10-20 6:52 ` Krishna Kumar2
2009-10-20 7:36 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Krishna Kumar2 @ 2009-10-20 6:52 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Hi Dave,
Sorry about the build failure. I did do a build and a stress test. But
I missed changing the name sk_record_tx_queue() in both sock.h
and dev.c when testing. I caught the miss before sending the patch,
but changed the name only in sock.h, and didn't do a final build
again. Sorry about this, will not assume next time.
I will fix this (including patch order) and resend after build and test.
Thanks,
- KK
David Miller <davem@davemloft.net> wrote on 10/20/2009 11:52:04 AM:
> David Miller <davem@davemloft.net>
> 10/20/2009 11:52 AM
>
> To
>
> Krishna Kumar2/India/IBM@IBMIN
>
> cc
>
> netdev@vger.kernel.org
>
> Subject
>
> build test your changes!
>
>
> Krishna, you add:
>
> +static inline void sk_tx_queue_set(struct sock *sk, int tx_queue)
> ...
> +static inline void sk_tx_queue_clear(struct sock *sk)
> ...
> +static inline int sk_tx_queue_get(const struct sock *sk)
> ...
> +static inline bool sk_tx_queue_recorded(const struct sock *sk)
>
> But then in the net/core/dev.c patch you go:
>
> + if (sk && sk->sk_dst_cache)
> + sk_record_tx_queue(sk, queue_index);
>
> I cannot see how you did a build test of this, it's absolutely
impossible.
>
> I'm reverting.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: build test your changes!
2009-10-20 6:52 ` Krishna Kumar2
@ 2009-10-20 7:36 ` Eric Dumazet
0 siblings, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2009-10-20 7:36 UTC (permalink / raw)
To: Krishna Kumar2; +Cc: David Miller, netdev
Krishna Kumar2 a écrit :
> Sorry about the build failure. I did do a build and a stress test. But
> I missed changing the name sk_record_tx_queue() in both sock.h
> and dev.c when testing. I caught the miss before sending the patch,
> but changed the name only in sock.h, and didn't do a final build
> again. Sorry about this, will not assume next time.
>
> I will fix this (including patch order) and resend after build and test.
>
Yes please, I am looking for your patches being added before my next round :)
(Specifically, I was waiting sizeof(struct sock_common) goes from 0x38 to 0x40
on 64 bit arches)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-20 7:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-20 6:22 build test your changes! David Miller
2009-10-20 6:52 ` Krishna Kumar2
2009-10-20 7:36 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).