From: Roel Kluin <roel.kluin@gmail.com>
To: netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
mcuos.com@gmail.com, davem@davemloft.net
Subject: [PATCH] net: Fix checks on unsigned in w90p910_ether_probe()
Date: Tue, 20 Oct 2009 20:14:36 +0200 [thread overview]
Message-ID: <4ADDFE0C.3020400@gmail.com> (raw)
ether->txirq and ->rxirq are unsigned
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/arm/w90p910_ether.c b/drivers/net/arm/w90p910_ether.c
index 25e2627..503c2ce 100644
--- a/drivers/net/arm/w90p910_ether.c
+++ b/drivers/net/arm/w90p910_ether.c
@@ -981,7 +981,7 @@ static int __devinit w90p910_ether_probe(struct platform_device *pdev)
{
struct w90p910_ether *ether;
struct net_device *dev;
- int error;
+ int error, ret;
dev = alloc_etherdev(sizeof(struct w90p910_ether));
if (!dev)
@@ -1010,17 +1010,19 @@ static int __devinit w90p910_ether_probe(struct platform_device *pdev)
goto failed_free_mem;
}
- ether->txirq = platform_get_irq(pdev, 0);
- if (ether->txirq < 0) {
+ ret = platform_get_irq(pdev, 0);
+ ether->txirq = ret;
+ if (ret < 0) {
dev_err(&pdev->dev, "failed to get ether tx irq\n");
- error = -ENXIO;
+ error = ret;
goto failed_free_io;
}
- ether->rxirq = platform_get_irq(pdev, 1);
- if (ether->rxirq < 0) {
+ ret = platform_get_irq(pdev, 1);
+ ether->rxirq = ret;
+ if (ret < 0) {
dev_err(&pdev->dev, "failed to get ether rx irq\n");
- error = -ENXIO;
+ error = ret;
goto failed_free_txirq;
}
next reply other threads:[~2009-10-20 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 18:14 Roel Kluin [this message]
2009-10-30 6:06 ` [PATCH] net: Fix checks on unsigned in w90p910_ether_probe() David Miller
2009-10-30 6:18 ` Wan ZongShun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADDFE0C.3020400@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=mcuos.com@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).