From: Gilad Ben-Yossef <gilad@codefidence.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org, ori@comsleep.com
Subject: Re: [PATCH RFC] Allow to turn off TCP window scale opt per route
Date: Wed, 21 Oct 2009 10:18:54 +0200 [thread overview]
Message-ID: <4ADEC3EE.2070301@codefidence.com> (raw)
In-Reply-To: <20091021104024.32adab23@s6510>
Stephen Hemminger wrote:
> On Tue, 20 Oct 2009 17:22:39 +0200
> Gilad Ben-Yossef <gilad@codefidence.com> wrote:
>
>
>> Add and use no window scale bit in the features field.
>>
>> Signed-off-by: Gilad Ben-Yossef <gilad@codefidence.com>
>> Sigend-off-by: Ori Finkelman <ori@comsleep.com>
>> Sigend-off-by: Yony Amit <yony@comsleep.com>
>>
>
> The same effect can by just using window limit on route
>
Actually, not exactly. There is a subtle but important difference
between "I support window scaling, but choose a scale of 0", which is
what your suggestion will imply and "I don't support window scaling at
all", which is what the suggested feature field does.
To make things more complicated, until the previous patch I sent, when
Linux would choose a window scale of zero for any reason, it would also
wrongfully report it does not support window scaling at all to the other
side, with some subtle bug caused by it, but this is no longer the
behavior and I believe rightly so.
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker & CTO
Codefidence Ltd.
Web: http://codefidence.com
Cell: +972-52-8260388
Skype: gilad_codefidence
Tel: +972-8-9316883 ext. 201
Fax: +972-8-9316884
Email: gilad@codefidence.com
Check out our Open Source technology and training blog - http://tuxology.net
"Sorry cannot parse this, its too long to be true :)"
-- Eric Dumazet on netdev mailing list
next prev parent reply other threads:[~2009-10-21 8:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 15:22 [PATCH RFC] Per route TCP options Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Only parse time stamp TCP option in time wait sock Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Allow tcp_parse_options to consult dst entry Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Add dst_feature to query route entry features Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Add the no SACK route option feature Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Allow disabling TCP timestamp options per route Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Allow to turn off TCP window scale opt " Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Allow disabling of DSACK TCP option " Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Document future removal of sysctl_tcp_* options Gilad Ben-Yossef
2009-10-21 1:40 ` [PATCH RFC] Allow to turn off TCP window scale opt per route Stephen Hemminger
2009-10-21 8:18 ` Gilad Ben-Yossef [this message]
2009-10-20 15:44 ` [PATCH RFC] Per route TCP options Eric Dumazet
2009-10-20 16:11 ` Gilad Ben-Yossef
2009-10-20 18:53 ` Ilpo Järvinen
2009-10-21 8:15 ` Gilad Ben-Yossef
2009-10-20 16:26 ` Rick Jones
2009-10-21 8:04 ` Gilad Ben-Yossef
2009-10-21 8:21 ` Florian Westphal
2009-10-21 8:40 ` Gilad Ben-Yossef
2009-10-21 0:36 ` David Miller
2009-10-21 8:10 ` Gilad Ben-Yossef
2009-10-21 2:13 ` Bill Fink
2009-10-21 8:27 ` Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADEC3EE.2070301@codefidence.com \
--to=gilad@codefidence.com \
--cc=netdev@vger.kernel.org \
--cc=ori@comsleep.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).