From: Gilad Ben-Yossef <gilad@codefidence.com>
To: Bill Fink <billfink@mindspring.com>
Cc: netdev@vger.kernel.org, ori@comsleep.com
Subject: Re: [PATCH RFC] Per route TCP options
Date: Wed, 21 Oct 2009 10:27:20 +0200 [thread overview]
Message-ID: <4ADEC5E8.9060205@codefidence.com> (raw)
In-Reply-To: <20091020221354.5a714323.billfink@mindspring.com>
Hi,
Bill Fink wrote:
> On Tue, 20 Oct 2009, Gilad Ben-Yossef wrote:
>
>
>> Turn the global sysctls allowing disabling of TCP SACK, DSCAK,
>> time stamp and window scale into per route entry feature options,
>> laying the ground to future removal of the relevant global sysctls.
>>
>> You really only want to disable SACK, DSACK, time stamp or window
>> scale if you've got a piece of broken networking equipment somewhere
>> as a stop gap until you can bring a big enough hammer to deal with
>> the broken network equipment. It doesn't make sense to "punish" the
>> entire connections going through the machine to destinations not
>> related to the broken equipment.
>>
>
> For certain test situations, it is sometimes desirable to globally
> disable TCP timestamps. Although I have not personally wanted to
> globally disable the other mentioned features, I can imagine test
> scenarios where it could be useful. Admittedly it could also be
> accomplished with per route features, just not as conveniently,
> especially if there are a large number of interfaces and/or routes.
>
>
I don't feel that strongly about it either way, just trying to hearken to
Linus "Linux is bloated" message by not fostering duplicate ways to do
the same thing... ;-)
If the consensus is to adopt the route features but leave the global
kill switches, I certainly have no problem with that.
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker & CTO
Codefidence Ltd.
Web: http://codefidence.com
Cell: +972-52-8260388
Skype: gilad_codefidence
Tel: +972-8-9316883 ext. 201
Fax: +972-8-9316884
Email: gilad@codefidence.com
Check out our Open Source technology and training blog - http://tuxology.net
"Sorry cannot parse this, its too long to be true :)"
-- Eric Dumazet on netdev mailing list
prev parent reply other threads:[~2009-10-21 8:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 15:22 [PATCH RFC] Per route TCP options Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Only parse time stamp TCP option in time wait sock Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Allow tcp_parse_options to consult dst entry Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Add dst_feature to query route entry features Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Add the no SACK route option feature Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Allow disabling TCP timestamp options per route Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Allow to turn off TCP window scale opt " Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Allow disabling of DSACK TCP option " Gilad Ben-Yossef
2009-10-20 15:22 ` [PATCH RFC] Document future removal of sysctl_tcp_* options Gilad Ben-Yossef
2009-10-21 1:40 ` [PATCH RFC] Allow to turn off TCP window scale opt per route Stephen Hemminger
2009-10-21 8:18 ` Gilad Ben-Yossef
2009-10-20 15:44 ` [PATCH RFC] Per route TCP options Eric Dumazet
2009-10-20 16:11 ` Gilad Ben-Yossef
2009-10-20 18:53 ` Ilpo Järvinen
2009-10-21 8:15 ` Gilad Ben-Yossef
2009-10-20 16:26 ` Rick Jones
2009-10-21 8:04 ` Gilad Ben-Yossef
2009-10-21 8:21 ` Florian Westphal
2009-10-21 8:40 ` Gilad Ben-Yossef
2009-10-21 0:36 ` David Miller
2009-10-21 8:10 ` Gilad Ben-Yossef
2009-10-21 2:13 ` Bill Fink
2009-10-21 8:27 ` Gilad Ben-Yossef [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADEC5E8.9060205@codefidence.com \
--to=gilad@codefidence.com \
--cc=billfink@mindspring.com \
--cc=netdev@vger.kernel.org \
--cc=ori@comsleep.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).