From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <stephen.hemminger@vyatta.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
Benjamin LaHaise <bcrl@lhnet.ca>
Subject: [PATCH iproute2] ip: Support IFLA_TXQLEN in ip link command
Date: Thu, 22 Oct 2009 16:15:07 +0200 [thread overview]
Message-ID: <4AE068EB.70005@gmail.com> (raw)
We currently use an expensive ioctl() to get device txqueuelen, while
rtnetlink gave it to us for free. This patch speeds up ip link operation
when many devices are registered.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index 267ecb3..f06a3f7 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -252,9 +252,12 @@ int print_linkinfo(const struct sockaddr_nl *who,
if (tb[IFLA_OPERSTATE])
print_operstate(fp, *(__u8 *)RTA_DATA(tb[IFLA_OPERSTATE]));
- if (filter.showqueue)
- print_queuelen(fp, (char*)RTA_DATA(tb[IFLA_IFNAME]));
-
+ if (filter.showqueue) {
+ if (tb[IFLA_TXQLEN])
+ fprintf(fp, "qlen %d ", *(int *)RTA_DATA(tb[IFLA_TXQLEN]));
+ else
+ print_queuelen(fp, (char *)RTA_DATA(tb[IFLA_IFNAME]));
+ }
if (!filter.family || filter.family == AF_PACKET) {
SPRINT_BUF(b1);
fprintf(fp, "%s", _SL_);
next reply other threads:[~2009-10-22 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 14:15 Eric Dumazet [this message]
2009-10-23 4:13 ` [PATCH iproute2] ip: Support IFLA_TXQLEN in ip link command Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE068EB.70005@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=bcrl@lhnet.ca \
--cc=netdev@vger.kernel.org \
--cc=stephen.hemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).