From: "Eugene T. Bordenkircher" <eugebo@gmail.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: linux.nics@intel.com
Subject: Problem with MDI/MDI-X auto-switching in E100 driver
Date: Thu, 22 Oct 2009 08:38:56 -0700 [thread overview]
Message-ID: <4AE07C90.2080901@gmail.com> (raw)
Around line 1466 of e100.c (git master) is the following code to turn on
MDI/MDI-X auto-switching if it is not already.
} else if ((nic->mac >= mac_82550_D102) || ((nic->flags & ich) &&
(mdio_read(netdev, nic->mii.phy_id, MII_TPISTATUS) & 0x8000) &&
!(nic->eeprom[eeprom_cnfg_mdix] & eeprom_mdix_enabled))) {
/* enable/disable MDI/MDI-X auto-switching. */
mdio_write(netdev, nic->mii.phy_id, MII_NCONFIG,
nic->mii.force_media ? 0 : NCONFIG_AUTO_SWITCH);
}
This code is broken in the case where an 8255x is used without magnetics. Per
Intel Application note 435, without the magnetics, auto switching is not
possible. The only way to turn this off without driver modifications is to set
the force_media flag via ethtool, which has the side effect of turning off all
auto-negotiation. This happens to be the case on a product I am currently
working on.
It seems a better solution to this is to trust the eeprom's configuration
rather than override it. Am I missing something or does this sound reasonable?
Eugene T. Bordenkircher
reply other threads:[~2009-10-22 15:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE07C90.2080901@gmail.com \
--to=eugebo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.nics@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).