From: William Allen Simpson <william.allen.simpson@gmail.com>
To: fangxiaozhi 00110321 <huananhu@huawei.com>
Cc: netdev@vger.kernel.org, kernel@vger.kernel.org, zihan@huawei.com,
greg@kroah.com, haegar@sdinet.de
Subject: Re: [PATCH 23/10] Optimize the upload speed for PPP connection.
Date: Fri, 23 Oct 2009 07:51:10 -0400 [thread overview]
Message-ID: <4AE198AE.6090800@gmail.com> (raw)
In-Reply-To: <f98f8abb3f92.3f92f98f8abb@huawei.com>
fangxiaozhi 00110321 wrote:
> From: fangxiaozhi <huananhu@huawei.com>
> 1. This patch is based on the kernel of 2.6.32-rc4
> 2. In this patch, we enlarge the out buffer size to optimize the upload speed for the ppp connection. Then it can support the upload of HSUPA data cards.
> Signed-off-by: fangxiaozhi <huananhu@huawei.com>
> -----------------------------------------------------------------------------------------
> --- a/drivers/net/ppp_async.c 2009-10-12 05:43:56.000000000 +0800
> +++ b/drivers/net/ppp_async.c 2009-10-15 16:29:56.000000000 +0800
> @@ -36,7 +36,7 @@
>
> #define PPP_VERSION "2.4.2"
>
> -#define OBUFSIZE 256
> +#define OBUFSIZE 2048
>
> /* Structure for storing local state. */
> struct asyncppp {
>
Repeat. I'd go further than that, my code usually made room for at least
a full MTU (MRU) with HDLC escaping. To minimize context switches, that
should be 3014 ((1500 MRU + 2 FCS + 4 header) * 2 escapes + 2 flags).
Even in the old days, when memory was tight, context switches and interrupt
time were more expensive, too. PPP is supposed to scale to OC-192.
next prev parent reply other threads:[~2009-10-23 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 9:47 [PATCH 23/10] Optimize the upload speed for PPP connection fangxiaozhi 00110321
2009-10-23 11:51 ` William Allen Simpson [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-10-28 7:30 PATCH 23/10]Optimize " fangxiaozhi 00110321
2009-11-17 8:45 ` [PATCH " fangxiaozhi 00110321
2009-11-17 9:08 ` David Miller
2009-11-17 9:15 ` Franko Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE198AE.6090800@gmail.com \
--to=william.allen.simpson@gmail.com \
--cc=greg@kroah.com \
--cc=haegar@sdinet.de \
--cc=huananhu@huawei.com \
--cc=kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zihan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).