[PATCH 23/10] Optimize the upload speed for PPP connection.

[PATCH 23/10] Optimize the upload speed for PPP connection.

[fangxiaozhi 00110321]

From: fangxiaozhi <huananhu@huawei.com>
1. This patch is based on the kernel of 2.6.32-rc4 
2. In this patch, we enlarge the out buffer size to optimize the upload speed for the ppp connection. Then it can support the upload of HSUPA data cards.
Signed-off-by: fangxiaozhi <huananhu@huawei.com>
-----------------------------------------------------------------------------------------
--- a/drivers/net/ppp_async.c	2009-10-12 05:43:56.000000000 +0800
+++ b/drivers/net/ppp_async.c	2009-10-15 16:29:56.000000000 +0800
@@ -36,7 +36,7 @@
 
 #define PPP_VERSION	"2.4.2"
 
-#define OBUFSIZE	256
+#define OBUFSIZE	2048
 
 /* Structure for storing local state. */
 struct asyncppp {

******************************************************************************************
 This email and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the information contained here in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email
 immediately and delete it!
 *****************************************************************************************

Re: [PATCH 23/10] Optimize the upload speed for PPP connection.

[William Allen Simpson]

fangxiaozhi 00110321 wrote:
> From: fangxiaozhi <huananhu@huawei.com>
> 1. This patch is based on the kernel of 2.6.32-rc4 
> 2. In this patch, we enlarge the out buffer size to optimize the upload speed for the ppp connection. Then it can support the upload of HSUPA data cards.
> Signed-off-by: fangxiaozhi <huananhu@huawei.com>
> -----------------------------------------------------------------------------------------
> --- a/drivers/net/ppp_async.c	2009-10-12 05:43:56.000000000 +0800
> +++ b/drivers/net/ppp_async.c	2009-10-15 16:29:56.000000000 +0800
> @@ -36,7 +36,7 @@
>  
>  #define PPP_VERSION	"2.4.2"
>  
> -#define OBUFSIZE	256
> +#define OBUFSIZE	2048
>  
>  /* Structure for storing local state. */
>  struct asyncppp {
> 
Repeat.  I'd go further than that, my code usually made room for at least
a full MTU (MRU) with HDLC escaping.  To minimize context switches, that
should be 3014 ((1500 MRU + 2 FCS + 4 header) * 2 escapes + 2 flags).

Even in the old days, when memory was tight, context switches and interrupt
time were more expensive, too.  PPP is supposed to scale to OC-192.

Re: [PATCH 23/10]Optimize the upload speed for PPP connection.

[fangxiaozhi 00110321]

Dear All:

    Excuse me, how about my patch now?
    
    Will my patch be fixed in the newest kernel version? What version is it?


Best Regards,

Franko Fang
2009-11-17
----- 原邮件 -----
发件人: fangxiaozhi 00110321 <huananhu@huawei.com>
日期: 星期三, 十月 28日, 2009 下午3:30
主题: Re: PATCH 23/10]Optimize the upload speed for PPP connection.
收件人: davem@davemloft.net,william.allen.simpson@gmail.com
抄送: netdev@vger.kernel.org,kernel@vger.kernel.org,zihan@huawei.com, greg@kroah.com,haegar@sdinet.de

> 
> Thanks your advice.
> 
> But generally, PAGE_SIZE is 4096, whether it is too large or not?
> 
> If PAGE_SIZE is really appropriate, then I can resubmit the patch.
> 
> Thanks very much.
> ----- Original Message ----- 
> From: "David Miller" <davem@davemloft.net>
> To: <william.allen.simpson@gmail.com>
> Cc: <huananhu@huawei.com>; <netdev@vger.kernel.org>; <linux-
> kernel@vger.kernel.org>; <zihan@huawei.com>; <greg@kroah.com>; 
> <haegar@sdinet.de>Sent: Saturday, October 24, 2009 9:46 PM
> Subject: Re: PATCH 23/10]Optimize the upload speed for PPP connection.
> 
> 
> > From: William Allen Simpson <william.allen.simpson@gmail.com>
> > Date: Fri, 23 Oct 2009 07:46:08 -0400
> > 
> >> Concur.  I'd go further than that, my code usually made room 
> for at
> >> least
> >> a full MTU (MRU) with HDLC escaping.  To minimize context switches,
> >> that
> >> should be 3014 ((1500 MRU + 2 FCS + 4 header) * 2 escapes + 2 
> flags).>> 
> >> Even in the old days, when memory was tight, context switches and
> >> interrupt
> >> time were more expensive, too.  PPP is supposed to scale to OC-192.
> > 
> > Actually I'd like to see ->obuf allocated externally and then
> > make it simply PAGE_SIZE.
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-
> kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> ******************************************************************************************
> This email and its attachments contain confidential information 
> from HUAWEI, which is intended only for the person or entity whose 
> address is listed above. Any use of the information contained here 
> in any way (including, but not limited to, total or partial 
> disclosure, reproduction, or dissemination) by persons other than 
> the intended recipient(s) is prohibited. If you receive this email 
> in error, please notify the sender by phone or email
> immediately and delete it!
> 
> *****************************************************************************************

Re: [PATCH 23/10]Optimize the upload speed for PPP connection.

[David Miller]

From: fangxiaozhi 00110321 <huananhu@huawei.com>
Date: Tue, 17 Nov 2009 16:45:30 +0800

>     Excuse me, how about my patch now?
>     
>     Will my patch be fixed in the newest kernel version? What version is it?

I said to make changes to your patch, and we'll look at the
updated version of the patch when you submit it.

The ball is in your court and has been so this entire time.

Re: [PATCH 23/10]Optimize the upload speed for PPP connection.

[Franko Fang]

OK, I will resubmit it immediately.

 Thanks.
----- Original Message ----- 
From: "David Miller" <davem@davemloft.net>
To: <huananhu@huawei.com>
Cc: <netdev@vger.kernel.org>; <william.allen.simpson@gmail.com>
Sent: Tuesday, November 17, 2009 5:08 PM
Subject: Re: [PATCH 23/10]Optimize the upload speed for PPP connection.


> From: fangxiaozhi 00110321 <huananhu@huawei.com>
> Date: Tue, 17 Nov 2009 16:45:30 +0800
> 
>>     Excuse me, how about my patch now?
>>     
>>     Will my patch be fixed in the newest kernel version? What version is it?
> 
> I said to make changes to your patch, and we'll look at the
> updated version of the patch when you submit it.
> 
> The ball is in your court and has been so this entire time.