From: Gilad Ben-Yossef <gilad@codefidence.com>
To: William Allen Simpson <william.allen.simpson@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 5/8] Allow disabling TCP timestamp options per route
Date: Sun, 25 Oct 2009 10:43:13 +0200 [thread overview]
Message-ID: <4AE40FA1.5040309@codefidence.com> (raw)
In-Reply-To: <4ADF5F5A.5090403@gmail.com>
Hi,
William Allen Simpson wrote:
>
>> diff --git a/include/linux/rtnetlink.h b/include/linux/rtnetlink.h
>> index 9c802a6..2ab8c75 100644
>> --- a/include/linux/rtnetlink.h
>> +++ b/include/linux/rtnetlink.h
>> @@ -378,7 +378,7 @@ enum
>>
>> #define RTAX_FEATURE_ECN 0x00000001
>> #define RTAX_FEATURE_NO_SACK 0x00000002
>> -#define RTAX_FEATURE_TIMESTAMP 0x00000004
>> +#define RTAX_FEATURE_NO_TSTAMP 0x00000004
>> #define RTAX_FEATURE_ALLFRAG 0x00000008
>>
> I just realized that unlike NO_WSCALE, this change assumes removing the
> sysctl and defaulting on.
No, it doesn't. This patch does not change the sysctl behavior in any
way. The RTAX_FEATURE_TIMESTAMP define is a currently a dead code not
used anywhere AFAIK.
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker & CTO
Codefidence Ltd.
Web: http://codefidence.com
Cell: +972-52-8260388
Skype: gilad_codefidence
Tel: +972-8-9316883 ext. 201
Fax: +972-8-9316884
Email: gilad@codefidence.com
Check out our Open Source technology and training blog - http://tuxology.net
"Sorry cannot parse this, its too long to be true :)"
-- Eric Dumazet on netdev mailing list
next prev parent reply other threads:[~2009-10-25 8:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 8:56 [PATCH v2 0/8] Per route TCP options Gilad Ben-Yossef
2009-10-21 8:56 ` [PATCH v2 1/8] Only parse time stamp TCP option in time wait sock Gilad Ben-Yossef
2009-10-21 9:49 ` William Allen Simpson
2009-10-21 10:07 ` Gilad Ben-Yossef
2009-10-21 18:59 ` William Allen Simpson
2009-10-25 8:41 ` Gilad Ben-Yossef
2009-10-21 8:56 ` [PATCH v2 2/8] Allow tcp_parse_options to consult dst entry Gilad Ben-Yossef
2009-10-21 13:03 ` Ilpo Järvinen
2009-10-21 14:07 ` Gilad Ben-Yossef
2009-10-22 9:41 ` Ilpo Järvinen
2009-10-21 8:56 ` [PATCH v2 3/8] Add dst_feature to query route entry features Gilad Ben-Yossef
2009-10-21 8:56 ` [PATCH v2 4/8] Add the no SACK route option feature Gilad Ben-Yossef
2009-10-21 19:22 ` William Allen Simpson
2009-10-25 8:44 ` Gilad Ben-Yossef
2009-10-21 8:56 ` [PATCH v2 5/8] Allow disabling TCP timestamp options per route Gilad Ben-Yossef
2009-10-21 19:22 ` William Allen Simpson
2009-10-25 8:43 ` Gilad Ben-Yossef [this message]
2009-10-21 8:56 ` [PATCH v2 6/8] Allow to turn off TCP window scale opt " Gilad Ben-Yossef
2009-10-21 8:57 ` [PATCH v2 7/8] Allow disabling of DSACK TCP option " Gilad Ben-Yossef
2009-10-21 8:57 ` [PATCH v2 8/8] Document future removal of sysctl_tcp_* options Gilad Ben-Yossef
2009-10-21 9:40 ` William Allen Simpson
2009-10-21 10:23 ` Gilad Ben-Yossef
2009-10-21 19:30 ` William Allen Simpson
2009-10-22 4:32 ` Bill Fink
2009-10-22 4:57 ` Eric Dumazet
2009-10-22 10:53 ` William Allen Simpson
2009-10-25 9:09 ` Gilad Ben-Yossef
2009-10-26 0:21 ` Bill Fink
2009-10-26 5:03 ` Eric Dumazet
2009-10-26 8:05 ` Gilad Ben-Yossef
2009-10-26 15:08 ` Bill Fink
2009-10-26 15:51 ` Gilad Ben-Yossef
2009-10-27 5:09 ` Bill Fink
2009-10-25 8:45 ` Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE40FA1.5040309@codefidence.com \
--to=gilad@codefidence.com \
--cc=netdev@vger.kernel.org \
--cc=william.allen.simpson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).