* r8169: Fix card drop incoming VLAN tagged MTU byte large jumbo frames
@ 2009-10-26 20:52 Raimonds Cicans
2009-10-30 5:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Raimonds Cicans @ 2009-10-26 20:52 UTC (permalink / raw)
To: romieu; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: r8169-vlan-jumbo.patch --]
[-- Type: text/plain, Size: 783 bytes --]
r8169 card drop incoming VLAN tagged MTU byte large jumbo frames
It looks to compare current and maximal packet sizes hardware use
'<' operator, not '<='.
Bug introduced by patch:
r8169: fix crash when large packets are received
Signed-off-by: Raimonds Cicans <ray@apollo.lv>
---
--- linux-2.6.31/drivers/net/r8169.c.orig 2009-10-26 20:57:47.256658618 +0200
+++ linux-2.6.31/drivers/net/r8169.c 2009-10-26 19:48:25.807252812 +0200
@@ -2365,7 +2365,7 @@ static u16 rtl_rw_cpluscmd(void __iomem
static void rtl_set_rx_max_size(void __iomem *ioaddr, unsigned int rx_buf_sz)
{
/* Low hurts. Let's disable the filtering. */
- RTL_W16(RxMaxSize, rx_buf_sz);
+ RTL_W16(RxMaxSize, rx_buf_sz + 1);
}
static void rtl8169_set_magic_reg(void __iomem *ioaddr, unsigned mac_version)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: r8169: Fix card drop incoming VLAN tagged MTU byte large jumbo frames
2009-10-26 20:52 r8169: Fix card drop incoming VLAN tagged MTU byte large jumbo frames Raimonds Cicans
@ 2009-10-30 5:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-10-30 5:55 UTC (permalink / raw)
To: ray; +Cc: romieu, netdev
From: Raimonds Cicans <ray@apollo.lv>
Date: Mon, 26 Oct 2009 22:52:37 +0200
> r8169 card drop incoming VLAN tagged MTU byte large jumbo frames
>
> It looks to compare current and maximal packet sizes hardware use
> '<' operator, not '<='.
>
> Bug introduced by patch:
> r8169: fix crash when large packets are received
>
> Signed-off-by: Raimonds Cicans <ray@apollo.lv>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-30 5:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-26 20:52 r8169: Fix card drop incoming VLAN tagged MTU byte large jumbo frames Raimonds Cicans
2009-10-30 5:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).