From: Ben Dooks <ben@simtec.co.uk>
To: "Figo.zhang" <figo1802@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH V2]NET/KS8695: add support NAPI for Rx
Date: Wed, 28 Oct 2009 10:57:50 +0000 [thread overview]
Message-ID: <4AE823AE.4040409@simtec.co.uk> (raw)
In-Reply-To: <1256653422.2148.23.camel@myhost>
Figo.zhang wrote:
> Add support NAPI Rx API for KS8695NET driver.
>
> v2, change the Rx function to NAPI.
>
> in <KS8695X Integrated Multi-port Gateway Solution Register Description
> v1.0>:
>
> Interrupt Enable Register (offset 0xE204)
> Bit29 : WAN MAC Receive Interrupt Enable
> Bit16 : LAN MAC Receive Interrupt Enable
>
> Interrupt Status Register (Offset 0xF208)
> Bit29: WAN MAC Receive Status
> Bit16: LAN MAC Receive Status
>
> see arch/arm/mach-ks8695/devices.c:
> ks8695_wan_resources[] and ks8695_lan_resources[]
> have IORESOURCE_IRQ , it have define the RX irq,
> for wan, irq = 29; for lan ,irq = 16.
> so we can do this read the interrupt status:
>
> unsigned long mask_bit = 1 << ksp->rx_irq;
> status = readl(KS8695_IRQ_VA + KS8695_INTST);
It would be nice to see some form of API addition to
the interrupt system to ack interrupts that have been
handled like this, since the irq layer is already
tracking the necessary IRQ->handler mappings.
--
Ben Dooks, Software Engineer, Simtec Electronics
http://www.simtec.co.uk/
next prev parent reply other threads:[~2009-10-28 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 14:23 [PATCH V2]NET/KS8695: add support NAPI for Rx Figo.zhang
2009-10-28 10:55 ` David Miller
2009-10-28 10:57 ` Ben Dooks [this message]
2009-10-28 12:06 ` Daniel Silverstone
2009-10-28 12:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE823AE.4040409@simtec.co.uk \
--to=ben@simtec.co.uk \
--cc=davem@davemloft.net \
--cc=figo1802@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).