From: Kristoffer Glembo <kristoffer@gaisler.com>
To: netdev@vger.kernel.org
Subject: phylib printouts
Date: Wed, 28 Oct 2009 17:33:19 +0100 [thread overview]
Message-ID: <4AE8724F.3010104@gaisler.com> (raw)
Hi,
There are some printouts in the phy abstraction library using pr_info().
Personally I would prefer if they used pr_debug() instead.
Especially the pr_info("%s: probed\n", bus->name) in mdiobus_register()
since in some cases I can't tolerate a console printout while the link
is down (we have an ethernet debug link and read the UART output through
the link).
Of course this is a very specific case but in general in embedded
systems (which I think is where the phylib is mainly used) I prefer the
driver and other kernel code to be rather silent if not debugging.
Any opinions? :)
Best regards,
Kristoffer Glembo
reply other threads:[~2009-10-28 16:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE8724F.3010104@gaisler.com \
--to=kristoffer@gaisler.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).