netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* phylib printouts
@ 2009-10-28 16:33 Kristoffer Glembo
  0 siblings, 0 replies; only message in thread
From: Kristoffer Glembo @ 2009-10-28 16:33 UTC (permalink / raw)
  To: netdev

Hi,

There are some printouts in the phy abstraction library using pr_info(). 
  Personally I would prefer if they used pr_debug() instead.

Especially the pr_info("%s: probed\n", bus->name) in mdiobus_register() 
since in some cases I can't tolerate a console printout while the link 
is down (we have an ethernet debug link and read the UART output through 
the link).

Of course this is a very specific case but in general in embedded 
systems (which I think is where the phylib is mainly used) I prefer the 
driver and other kernel code to be rather silent if not debugging.

Any opinions? :)

Best regards,
Kristoffer Glembo

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-10-28 16:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-28 16:33 phylib printouts Kristoffer Glembo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).