From: Patrick McHardy <kaber@trash.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/6] vlan: Optimize multiple unregistration
Date: Thu, 29 Oct 2009 14:45:44 +0100 [thread overview]
Message-ID: <4AE99C88.40403@trash.net> (raw)
In-Reply-To: <4AE8ADE7.1010909@gmail.com>
Eric Dumazet wrote:
> Patrick McHardy a écrit :
>>> +{
>>> + LIST_HEAD(list);
>>> + int i;
>>> + struct net_device *vlandev;
>>> + struct vlan_group save;
>>> +
>>> + memcpy(&save, grp, sizeof(save));
>>> + memset(&grp->vlan_devices_arrays, 0, sizeof(grp->vlan_devices_arrays));
>> This shouldn't be necessary since the lower device is already in the
>> process of being unregistered. If it was necessary, it could cause
>> crashes since the individual pointers are not set to zero atomically.
>> Or maybe I'm misunderstanding the purpose entirely :)
>
> Very good point indeed, even if in practice memset() use long word transferts
>
> I'll make a cleanup patch, or do you want to do it ?
I can take care of this, patch will follow shortly.
next prev parent reply other threads:[~2009-10-29 13:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 17:06 [PATCH 4/6] vlan: Optimize multiple unregistration Eric Dumazet
2009-10-28 20:05 ` Patrick McHardy
2009-10-28 20:47 ` Eric Dumazet
2009-10-29 13:45 ` Patrick McHardy [this message]
2009-10-29 14:23 ` Patrick McHardy
2009-10-29 14:30 ` Eric Dumazet
2009-10-29 14:33 ` Patrick McHardy
2009-10-29 14:43 ` Eric Dumazet
2009-10-29 17:25 ` Patrick McHardy
2009-10-30 6:30 ` Eric Dumazet
2009-10-30 6:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE99C88.40403@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).