From: William Allen Simpson <william.allen.simpson@gmail.com>
To: Linux Kernel Network Developers <netdev@vger.kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
"Joe Perches" <joe@perches.com>
Subject: Re: [net-next-2.6 PATCH v4 3/3] TCPCT part 1c: initial SYN exchange with SYNACK data
Date: Mon, 02 Nov 2009 13:10:04 -0500 [thread overview]
Message-ID: <4AEF207C.9030002@gmail.com> (raw)
In-Reply-To: <4AE6E7C0.2050408@gmail.com>
Another style question:
+struct tcp_extend_values {
+ u8 cookie_bakery[TCP_COOKIE_MAX];
+ u8 cookie_plus;
+ u8 cookie_in_always:1,
+ cookie_out_never:1;
+};
+
+static inline struct tcp_extend_values *tcp_xv(const struct request_values *rvp)
+{
+ return (struct tcp_extend_values *)rvp;
+}
Some examples have "struct request_values" as the first element, others
don't. I started with it, and then removed it (as essentially nil).
Is there a preference?
next prev parent reply other threads:[~2009-11-02 18:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 12:11 [net-next-2.6 v4 0/4] TCPCT part1: cookie option exchange William Allen Simpson
2009-10-27 12:15 ` [net-next-2.6 PATCH v4 1/3] TCPCT part 1a: add request_values parameter for sending SYNACK William Allen Simpson
2009-11-01 19:13 ` Eric Dumazet
2009-10-27 12:18 ` [net-next-2.6 PATCH v4 2/3] TCPCT part 1b: sysctl_tcp_cookie_size, socket option TCP_COOKIE_TRANSACTIONS, functions William Allen Simpson
2009-11-01 19:13 ` Eric Dumazet
2009-11-02 10:45 ` William Allen Simpson
2009-11-02 10:51 ` David Miller
2009-11-02 17:54 ` William Allen Simpson
2009-10-27 12:29 ` [net-next-2.6 PATCH v4 3/3] TCPCT part 1c: initial SYN exchange with SYNACK data William Allen Simpson
2009-10-28 14:17 ` Eric Dumazet
2009-10-28 17:14 ` William Allen Simpson
2009-11-01 19:19 ` Eric Dumazet
2009-11-02 12:25 ` William Allen Simpson
2009-11-02 12:57 ` Ilpo Järvinen
2009-11-02 16:17 ` William Allen Simpson
2009-11-02 17:04 ` Eric Dumazet
2009-11-02 20:38 ` William Allen Simpson
2009-11-02 13:31 ` Eric Dumazet
2009-11-02 17:00 ` Joe Perches
2009-11-02 17:50 ` William Allen Simpson
2009-11-02 18:10 ` William Allen Simpson [this message]
2009-11-02 18:16 ` Joe Perches
2009-11-02 20:15 ` William Allen Simpson
2009-11-03 5:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEF207C.9030002@gmail.com \
--to=william.allen.simpson@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).