From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] net: Support specifying the network namespace upon device creation.
Date: Tue, 03 Nov 2009 10:56:02 +0100 [thread overview]
Message-ID: <4AEFFE32.4050808@gmail.com> (raw)
In-Reply-To: <m1ws28ey3k.fsf@fess.ebiederm.org>
Eric W. Biederman a écrit :
> Eric Dumazet <eric.dumazet@gmail.com> writes:
>> Very nice, with only one long line you could wrap differently.
>
> Say again? Was that very nice with respect to the rest of the patch?
> Or sarcasm because I overlooked this wrap at 80 columns
> opportunity in ipgre?
>
> Eric
>>
>>> -static int ipgre_newlink(struct net_device *dev, struct nlattr *tb[],
>>> +static int ipgre_newlink(struct net *src_net, struct net_device *dev, struct nlattr *tb[],
>>> struct nlattr *data[])
>>> {
>>> struct ip_tunnel *nt;
Hmm, I am very sorry you take it as a sarcasm, I would not treat you or anyone like that.
I was basically Acking your patch, with only one minor note about one line becoming a bit long.
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
It would be better to write :
static int ipgre_newlink(struct net *src_net, struct net_device *dev,
struct nlattr *tb[], struct nlattr *data[])
next prev parent reply other threads:[~2009-11-03 9:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 9:03 [PATCH] net: Support specifying the network namespace upon device creation Eric W. Biederman
2009-11-03 9:28 ` Eric Dumazet
2009-11-03 9:50 ` Eric W. Biederman
2009-11-03 9:56 ` Eric Dumazet [this message]
2009-11-03 10:06 ` Eric W. Biederman
2009-11-03 10:05 ` David Miller
2009-11-03 10:16 ` Eric Dumazet
2009-11-03 10:44 ` David Miller
2009-11-03 13:26 ` [PATCH net-next-2.6] net: cleanup include/net Eric Dumazet
2009-11-04 13:07 ` David Miller
2009-11-04 17:48 ` [PATCH net-next-2.6] net: cleanup include/linux Eric Dumazet
2009-11-04 17:51 ` David Miller
2009-11-03 10:32 ` [PATCH] net: Support specifying the network namespace upon device creation Eric W. Biederman
2009-11-08 8:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEFFE32.4050808@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).