netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Devera <martin.devera@cdi.cz>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
	Jamal Hadi Salim <hadi@cyberus.ca>,
	netdev@vger.kernel.org
Subject: Re: [PATCH] sch_htb.c consume the classes's tokens bellow the 	HTB_CAN_SEND level
Date: Wed, 04 Nov 2009 12:58:01 +0100	[thread overview]
Message-ID: <4AF16C49.409@cdi.cz> (raw)
In-Reply-To: <412e6f7f0911040330uc5ebbcekfef57854fce501f@mail.gmail.com>

Changli Gao wrote:
> On Wed, Nov 4, 2009 at 6:58 PM, Martin Devera <martin.devera@cdi.cz> wrote:
>> Hello,
>>
>> yes you are right. If I remember correctly, I tried to charge "rate"
>> tokens up to root in early versions (which makes some sense) but problem
>> is with many interior classes stuck at extreme mbuffer value, losing
>> responsivity.
> 
> It is strange. Would you like describe it more clearly?

Ahh I'm starting to understand. You are concerned mainly with

cl->tokens += diff;     /* we moved t_c; update tokens */

am I right ?

  parent reply	other threads:[~2009-11-04 11:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-03  2:41 [PATCH] sch_htb.c consume the classes's tokens bellow the HTB_CAN_SEND level Changli Gao
2009-11-03  8:00 ` Jarek Poplawski
2009-11-03  9:47   ` Changli Gao
2009-11-03 10:05     ` Jarek Poplawski
2009-11-03 13:18       ` Changli Gao
2009-11-03 23:00         ` Jarek Poplawski
2009-11-04  1:53           ` Changli Gao
2009-11-04  8:28             ` Jarek Poplawski
2009-11-04  9:16               ` Changli Gao
2009-11-04 10:42                 ` Jarek Poplawski
2009-11-04 10:58                   ` Martin Devera
2009-11-04 11:30                     ` Changli Gao
2009-11-04 11:51                       ` Martin Devera
2009-11-04 11:58                       ` Martin Devera [this message]
2009-11-04 12:08                         ` Changli Gao
2009-11-04 12:15                           ` Martin Devera
2009-11-05  5:44                             ` Changli Gao
2009-11-04 11:21                   ` Changli Gao
2009-11-04 11:49                     ` Jarek Poplawski
2009-11-04 12:01                       ` Changli Gao
2009-11-04 12:11                         ` Jarek Poplawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF16C49.409@cdi.cz \
    --to=martin.devera@cdi.cz \
    --cc=hadi@cyberus.ca \
    --cc=jarkao2@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiaosuo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).