From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ryousei Takano <ryousei@gmail.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
Patrick McHardy <kaber@trash.net>,
Linux Netdev List <netdev@vger.kernel.org>,
takano-ryousei@aist.go.jp
Subject: Re: HTB accuracy on 10GbE
Date: Wed, 04 Nov 2009 18:03:07 +0100 [thread overview]
Message-ID: <4AF1B3CB.1050008@gmail.com> (raw)
In-Reply-To: <b30d1c3b0911040831y7aeac556raf7cae9106b5bc7b@mail.gmail.com>
Ryousei Takano a écrit :
> Hi Eric,
>
> Thanks for your suggestion.
>
> On Wed, Nov 4, 2009 at 8:31 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> Ryousei Takano a écrit :
>>
>>> I tried iperf with 60 seconds samples. I got the almost same result.
>>>
>>> Here is the result:
>>> sender receiver
>>> 1.000 1.00 1.00
>>> 2.000 2.01 2.01
>>> 3.000 3.03 3.02
>>> 4.000 4.07 4.07
>>> 5.000 5.05 5.05
>>> 6.000 6.16 6.16
>>> 7.000 7.22 7.22
>>> 8.000 8.15 8.15
>>> 9.000 9.23 9.23
>>> 9.900 9.69 9.69
>>>
>> One thing to consider is the estimation error in qdisc_l2t(), rate table has only 256 slots
>>
>> static inline u32 qdisc_l2t(struct qdisc_rate_table* rtab, unsigned int pktlen)
>> {
>> int slot = pktlen + rtab->rate.cell_align + rtab->rate.overhead;
>> if (slot < 0)
>> slot = 0;
>> slot >>= rtab->rate.cell_log;
>> if (slot > 255)
>> return (rtab->data[255]*(slot >> 8) + rtab->data[slot & 0xFF]);
>> return rtab->data[slot];
>> }
>>
>>
>> Maybe you can try changing class mtu to 40000 instead of 9000, and quantum to 60000 too
>>
>> tc class add dev $DEV parent 1: classid 1:1 htb rate ${rate}mbit mtu 40000 quantum 60000
>>
>> (because your tcp stack sends large buffers ( ~ 60000 bytes) as your NIC can offload tcp segmentation)
>>
>>
> You are right!
> I am using TSO. The myri10ge driver is passing 64KB packets to the NIC.
> I changed the class mtu parameter to 64000 instead of 9000.
>
> Here is the result:
> 1.000 1.00
> 2.000 2.01
> 3.000 2.99
> 4.000 4.01
> 5.000 5.01
> 6.000 6.04
> 7.000 7.06
> 8.000 8.09
> 9.000 9.11
> 9.900 9.64
>
> It's not so bad!
> For more information, I updated the results on my page.
>
In fact, I gave you 40000 because rtab will contain 256 elements from 0 to 65280
If you use 64000, you lose some precision (for small packets for example)
next prev parent reply other threads:[~2009-11-04 17:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 7:22 HTB accuracy on 10GbE Ryousei Takano
2009-11-02 8:17 ` Badalian Vyacheslav
2009-11-02 15:43 ` Patrick McHardy
2009-11-02 20:53 ` Stephen Hemminger
2009-11-03 7:43 ` Badalian Vyacheslav
2009-11-03 9:33 ` Jarek Poplawski
2009-11-03 10:13 ` Badalian Vyacheslav
2009-11-03 10:54 ` Jarek Poplawski
2009-11-03 11:13 ` Badalian Vyacheslav
2009-11-04 3:13 ` Ryousei Takano
2009-11-04 3:45 ` Ryousei Takano
2009-11-04 5:03 ` Eric Dumazet
2009-11-04 5:27 ` Eric Dumazet
2009-11-04 8:19 ` Ryousei Takano
2009-11-04 11:31 ` Eric Dumazet
2009-11-04 13:39 ` Jarek Poplawski
2009-11-04 16:31 ` Ryousei Takano
2009-11-04 17:03 ` Eric Dumazet [this message]
2009-11-05 7:08 ` Ryousei Takano
2009-11-05 7:10 ` Eric Dumazet
2009-11-05 10:15 ` Ryousei Takano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF1B3CB.1050008@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=ryousei@gmail.com \
--cc=shemminger@vyatta.com \
--cc=takano-ryousei@aist.go.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).