From: Patrick McHardy <kaber@trash.net>
To: Hannes Eder <heder@google.com>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_nat_helper: tidy up adjust_tcp_sequence
Date: Thu, 05 Nov 2009 15:53:31 +0100 [thread overview]
Message-ID: <4AF2E6EB.9000304@trash.net> (raw)
In-Reply-To: <20090922155911.20008.96214.stgit@jazzy.zrh.corp.google.com>
Hannes Eder wrote:
> The variable 'other_way' gets initialized but is not read afterwards,
> so remove it. Pass the right arguments to a pr_debug call.
>
> While being at tidy up a bit and it fix this checkpatch warning:
> WARNING: suspect code indent for conditional statements
>
> Signed-off-by: Hannes Eder <heder@google.com>
>
Applied with some minor changes (use enum ip_conntrack_dir instead
of int, use function name literally instead of "%s()" with __func__).
prev parent reply other threads:[~2009-11-05 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 16:00 [PATCH] netfilter: nf_nat_helper: tidy up adjust_tcp_sequence Hannes Eder
2009-11-05 14:53 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF2E6EB.9000304@trash.net \
--to=kaber@trash.net \
--cc=heder@google.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).