From: Brian Haley <brian.haley@hp.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next2.6] ipv6: avoid dev_hold()/dev_put() in rawv6_bind()
Date: Fri, 06 Nov 2009 11:48:46 -0500 [thread overview]
Message-ID: <4AF4536E.7090803@hp.com> (raw)
In-Reply-To: <4AF40022.6050100@gmail.com>
Eric Dumazet wrote:
> @@ -257,6 +257,7 @@ static int rawv6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len)
> if (sk->sk_state != TCP_CLOSE)
> goto out;
>
> + rcu_read_unlock();
> /* Check if the address belongs to the host. */
> if (addr_type != IPV6_ADDR_ANY) {
> struct net_device *dev = NULL;
This was supposed to be rcu_read_lock(), right?
-Brian
next prev parent reply other threads:[~2009-11-06 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 10:53 [PATCH net-next2.6] ipv6: avoid dev_hold()/dev_put() in rawv6_bind() Eric Dumazet
2009-11-06 16:48 ` Brian Haley [this message]
2009-11-06 17:01 ` Eric Dumazet
2009-11-08 8:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF4536E.7090803@hp.com \
--to=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).