From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH] can: fix WARN_ON dump in net/core/rtnetlink.c:rtmsg_ifinfo() Date: Sun, 08 Nov 2009 10:30:51 +0100 Message-ID: <4AF68FCB.4050103@grandegger.com> References: <4AF54389.1090309@grandegger.com> <20091108.004602.213063654.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Miller Return-path: In-Reply-To: <20091108.004602.213063654.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org David Miller wrote: > From: Wolfgang Grandegger > Date: Sat, 07 Nov 2009 10:53:13 +0100 > >> On older kernels, e.g. 2.6.27, a WARN_ON dump in rtmsg_ifinfo() >> is thrown when the CAN device is registered due to insufficient >> skb space, as reported by various users. This patch adds the >> rtnl_link_ops "get_size" to fix the problem. I think this patch >> is required for more recent kernels as well, even if no WARN_ON >> dumps are triggered. Maybe we also need "get_xstats_size" for >> the CAN xstats. >> >> Signed-off-by: Wolfgang Grandegger > > Applied to net-2.6, thanks Wolfgang. Thanks, the commit message included some questions. What is the rule using the rtnl_link_ops "get_size" or "get_xstats_size". Are these mandatory if the corresponding fill functions are used? Wolfgang.