From: Eric Dumazet <eric.dumazet@gmail.com>
To: xiaosuo@gmail.com
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] check the return value of ndo_select_queue()
Date: Mon, 09 Nov 2009 11:02:42 +0100 [thread overview]
Message-ID: <4AF7E8C2.90707@gmail.com> (raw)
In-Reply-To: <4AF7E5F1.6080608@gmail.com>
Eric Dumazet a écrit :
>
> Yes, but this is a _very_ unlikely condition (a bug IMHO), so you could use :
>
> if (unlikely(queue_index >= dev->real_num_tx_queues)) {
> ...
> }
>
> (This unlikely() clause is implied in WARN... macros)
>
Also, you want to trigger this message only once, or ratelimit it at least
next prev parent reply other threads:[~2009-11-09 10:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 9:34 [PATCH] check the return value of ndo_select_queue() Changli Gao
2009-11-09 9:50 ` Eric Dumazet
2009-11-09 10:02 ` Eric Dumazet [this message]
2009-11-09 11:29 ` Changli Gao
-- strict thread matches above, loose matches on Subject: below --
2009-11-14 0:50 Changli Gao
2009-11-14 7:54 ` Eric Dumazet
2009-11-14 12:14 ` Changli Gao
2009-11-14 12:37 ` Eric Dumazet
2009-11-16 6:09 ` David Miller
2009-11-10 1:42 Changli Gao
2009-11-10 3:43 ` Eric Dumazet
2009-11-13 22:09 ` David Miller
2009-11-09 7:17 Changli Gao
2009-11-09 7:26 ` David Miller
2009-11-09 8:44 ` Changli Gao
2009-11-09 9:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF7E8C2.90707@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).