From: Eric Dumazet <eric.dumazet@gmail.com>
To: Christopher Zimmermann <madroach@zakweb.de>
Cc: "Marcus D. Leech" <mleech@ripnet.com>, netdev@vger.kernel.org
Subject: Re: Possible bug: SO_TIMESTAMPING 2.6.30+
Date: Tue, 10 Nov 2009 09:44:20 +0100 [thread overview]
Message-ID: <4AF927E4.7040306@gmail.com> (raw)
In-Reply-To: <20091110091252.1667d27d@pundit>
Christopher Zimmermann a écrit :
> On Mon, 09 Nov 2009 19:40:30 -0500
> "Marcus D. Leech" <mleech@ripnet.com> wrote:
>
>
>> I know that Patrick Ohly has essentially moved on from doing the
>> SO_TIMESTAMPING stuff, so
>> who's maintaining it now?
>
> I worked on it a month ago or so and have a patchset from Patick Ohly
> and some changes by me which fix software timestamping and make the
> ioctl interface to the hardware more flexible (keeping backwards
> compatibility). Patches are attached.
> Still I never tried IPv6 and don't think the patches do anything about
> it.
> It would be nice to know weather software tx timestamps work
> with/without the patches.
>
>
> Christopher
>
I see some sock_put()/sock_hold() stuff in your second patch.
We removed these things on transmit path, please dont add them back...
If skb->sk is set, it probably also has a destructor and a reference already taken.
(This reference being on sk_wmem_alloc by the way, not on sk_refcnt)
You probably can try to change skb destructor ?
next prev parent reply other threads:[~2009-11-10 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 0:40 Possible bug: SO_TIMESTAMPING 2.6.30+ Marcus D. Leech
2009-11-10 8:12 ` Christopher Zimmermann
2009-11-10 8:44 ` Eric Dumazet [this message]
2009-11-10 22:03 ` Christopher Zimmermann
2009-11-11 0:13 ` Marcus D. Leech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF927E4.7040306@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=madroach@zakweb.de \
--cc=mleech@ripnet.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).