From: Eric Dumazet <eric.dumazet@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: [RFC] vlan: GRO rx statistics
Date: Tue, 10 Nov 2009 17:52:32 +0100 [thread overview]
Message-ID: <4AF99A50.5080301@gmail.com> (raw)
It seems vlan interfaces with hardware-assisted VLAN reception
dont have rx statistics.
Following patch cures the problem for me but I have no idea
if it is correct ?
Another problem about all rx stats is about multi rx queues devices.
Several cpus can access these counters in parallel ?
diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c
index 8d5ca2a..e13b007 100644
--- a/net/8021q/vlan_core.c
+++ b/net/8021q/vlan_core.c
@@ -89,6 +89,11 @@ vlan_gro_common(struct napi_struct *napi, struct vlan_group *grp,
if (!skb->dev)
goto drop;
+ skb->dev->stats.rx_packets++;
+ skb->dev->stats.rx_bytes += skb->len;
+ if (skb->pkt_type == PACKET_MULTICAST)
+ skb->dev->stats.multicast++;
+
for (p = napi->gro_list; p; p = p->next) {
NAPI_GRO_CB(p)->same_flow =
p->dev == skb->dev && !compare_ether_header(
next reply other threads:[~2009-11-10 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 16:52 Eric Dumazet [this message]
2009-11-13 16:41 ` [RFC] vlan: GRO rx statistics Eric Dumazet
2009-11-13 16:44 ` Eric Dumazet
2009-11-14 1:27 ` Herbert Xu
2009-11-14 7:27 ` Eric Dumazet
2009-11-15 19:35 ` Eric Dumazet
2009-11-16 5:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF99A50.5080301@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).