netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: vlan/macvlan 02/02: propagate transmission state to upper layers
Date: Tue, 10 Nov 2009 17:56:11 +0100	[thread overview]
Message-ID: <4AF99B2B.7040507@trash.net> (raw)
In-Reply-To: <20091110084814.02593603@nehalam>

Stephen Hemminger wrote:
> On Tue, 10 Nov 2009 17:14:24 +0100
> Patrick McHardy <kaber@trash.net> wrote:
> 
>>   vlan/macvlan: propagate transmission state to upper layers
>>     
>>     Both vlan and macvlan devices usually don't use a qdisc and immediately
>>     queue packets to the underlying device. Propagate transmission state of
>>     the underlying device to the upper layers so they can react on congestion
>>     and/or inform the sending process.
>>     
>>     Signed-off-by: Patrick McHardy <kaber@trash.net>
> 
> 
> Bridging and bonding have same issue, but the solution is more difficult.

Yes, in both cases the packet might be sent out on multiple
interfaces, so its not really clear which state we should
propagate. I guess it would make sense to indicate an error
if transmission on *all* interfaces fail, but I'm not sure
about the other cases.

      reply	other threads:[~2009-11-10 16:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10 16:14 vlan/macvlan 02/02: propagate transmission state to upper layers Patrick McHardy
2009-11-10 16:48 ` Stephen Hemminger
2009-11-10 16:56   ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF99B2B.7040507@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).