From: Oliver Hartkopp <oliver@hartkopp.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 10/10] CAN: use dev_get_by_index_rcu
Date: Wed, 11 Nov 2009 06:54:24 +0100 [thread overview]
Message-ID: <4AFA5190.60600@hartkopp.net> (raw)
In-Reply-To: <4AF9B21E.50805@gmail.com>
Eric Dumazet wrote:
> Stephen Hemminger a écrit :
>> Use new function to avoid doing read_lock().
>>
>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>>
>> --- a/net/can/bcm.c 2009-11-10 09:45:16.301376272 -0800
>> +++ b/net/can/bcm.c 2009-11-10 09:46:30.125005956 -0800
>> @@ -139,13 +139,13 @@ static char *bcm_proc_getifname(char *re
>> if (!ifindex)
>> return "any";
>>
>> - read_lock(&dev_base_lock);
>> - dev = __dev_get_by_index(&init_net, ifindex);
>> + rcu_read_lock();
>> + dev = dev_get_by_index_rcu(&init_net, ifindex);
>> if (dev)
>> strcpy(result, dev->name);
>> else
>> strcpy(result, "???");
>> - read_unlock(&dev_base_lock);
>> + rcu_read_unlock();
>>
>> return result;
>> }
>>
>
> I was pretty sure I had already done this one...
>
> Ah yes, that was planned after a bugfix for net-2.6.
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>
Thanks everyone!
Signed-off-by: Oliver Hartkopp <oliver@hartkopp.net>
next prev parent reply other threads:[~2009-11-11 5:54 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 17:54 [PATCH 00/10] netdev: get rid of read_lock(&dev_base_lock) usages Stephen Hemminger
2009-11-10 17:54 ` [PATCH 01/10] netdev: add netdev_continue_rcu Stephen Hemminger
2009-11-10 18:19 ` Eric Dumazet
2009-11-11 6:47 ` David Miller
2009-11-10 19:39 ` Paul E. McKenney
2009-11-10 17:54 ` [PATCH 02/10] vlan: eliminate use of dev_base_lock Stephen Hemminger
2009-11-10 18:20 ` Eric Dumazet
2009-11-11 6:47 ` David Miller
2009-11-10 17:54 ` [PATCH 03/10] net: use rcu for network scheduler API Stephen Hemminger
2009-11-10 18:20 ` Eric Dumazet
2009-11-11 6:47 ` David Miller
2009-11-10 17:54 ` [PATCH 04/10] AOE: use rcu to find network device Stephen Hemminger
2009-11-10 18:23 ` Eric Dumazet
2009-11-10 20:01 ` Ed Cashin
2009-11-10 23:06 ` Stephen Hemminger
2009-11-10 23:53 ` Stephen Hemminger
2009-11-11 6:48 ` David Miller
2009-11-12 14:33 ` Ed Cashin
2009-11-12 17:10 ` Stephen Hemminger
2009-11-12 18:07 ` Ed Cashin
2009-11-12 19:09 ` Stephen Hemminger
2009-11-18 16:49 ` Ed Cashin
2009-11-11 14:22 ` Ed Cashin
2009-11-13 21:39 ` Ed Cashin
2009-11-13 22:24 ` Stephen Hemminger
2009-11-10 17:54 ` [PATCH 05/10] parisc: use RCU " Stephen Hemminger
2009-11-10 18:26 ` Eric Dumazet
2009-11-11 6:48 ` David Miller
2009-11-10 17:54 ` [PATCH 06/10] s390: use RCU to walk list of network devices Stephen Hemminger
2009-11-10 18:27 ` Eric Dumazet
2009-11-10 18:29 ` Stephen Hemminger
2009-11-10 18:40 ` Eric Dumazet
2009-11-11 6:49 ` David Miller
2009-11-10 17:54 ` [PATCH 07/10] decnet: use RCU to find " Stephen Hemminger
2009-11-10 18:43 ` Eric Dumazet
2009-11-10 18:50 ` Stephen Hemminger
2009-11-10 18:24 ` steve
2009-11-11 17:39 ` [PATCH 1/2] decnet: add RTNL lock when reading address list Stephen Hemminger
2009-11-11 17:40 ` [PATCH 2/2] decnet: convert dndev_lock to spinlock Stephen Hemminger
2009-11-12 3:56 ` David Miller
2009-11-12 3:56 ` [PATCH 1/2] decnet: add RTNL lock when reading address list David Miller
2009-11-10 19:25 ` [PATCH 07/10] decnet: use RCU to find network devices Eric Dumazet
2009-11-11 6:49 ` David Miller
2009-11-10 17:54 ` [PATCH 08/10] ipv6: use RCU to walk list of " Stephen Hemminger
2009-11-11 6:50 ` David Miller
2009-11-12 3:34 ` [PATCH net-next-2.6] " Eric Dumazet
2009-11-14 4:39 ` David Miller
2009-11-10 17:54 ` [PATCH 09/10] IPV4: use rcu to walk list of devices in IGMP Stephen Hemminger
2009-11-10 18:47 ` Eric Dumazet
2009-11-11 6:50 ` David Miller
2009-11-10 17:54 ` [PATCH 10/10] CAN: use dev_get_by_index_rcu Stephen Hemminger
2009-11-10 18:34 ` Eric Dumazet
2009-11-11 5:54 ` Oliver Hartkopp [this message]
2009-11-11 6:50 ` David Miller
2009-11-10 18:18 ` [PATCH 00/10] netdev: get rid of read_lock(&dev_base_lock) usages Eric Dumazet
2009-11-10 18:22 ` Stephen Hemminger
2009-11-10 18:24 ` Stephen Hemminger
2009-11-10 18:39 ` Eric Dumazet
2009-11-10 18:53 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFA5190.60600@hartkopp.net \
--to=oliver@hartkopp.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).