* sparse noise due to patch "net: fix kmemcheck annotations"
@ 2009-11-11 20:41 Stefan Richter
2009-11-11 21:13 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Richter @ 2009-11-11 20:41 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev
Hi Eric,
with above mentioned patch, committed as
14d18a81b5171d4433e41129619c75748b4f4d26, you changed
struct sk_buff {
...
__be16 protocol;
...
}
to
__be16 protocol:16;
This introduces the following warning from sparse:
include/linux/skbuff.h:357:41: error: invalid bitfield specifier for
type restricted __be16.
So, one checker satisfied, another disturbed? Any idea how to get this
sparse-clean again?
--
Stefan Richter
-=====-==--= =-== -=-==
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: sparse noise due to patch "net: fix kmemcheck annotations"
2009-11-11 20:41 sparse noise due to patch "net: fix kmemcheck annotations" Stefan Richter
@ 2009-11-11 21:13 ` Eric Dumazet
2009-11-11 21:42 ` Stefan Richter
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2009-11-11 21:13 UTC (permalink / raw)
To: Stefan Richter; +Cc: netdev
Stefan Richter a écrit :
> Hi Eric,
>
> with above mentioned patch, committed as
> 14d18a81b5171d4433e41129619c75748b4f4d26, you changed
>
> struct sk_buff {
> ...
> __be16 protocol;
> ...
> }
> to
> __be16 protocol:16;
>
> This introduces the following warning from sparse:
>
> include/linux/skbuff.h:357:41: error: invalid bitfield specifier for
> type restricted __be16.
>
> So, one checker satisfied, another disturbed? Any idea how to get this
> sparse-clean again?
No problem here... how do you get this error, and what is your sparse version ?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: sparse noise due to patch "net: fix kmemcheck annotations"
2009-11-11 21:13 ` Eric Dumazet
@ 2009-11-11 21:42 ` Stefan Richter
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Richter @ 2009-11-11 21:42 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev
Eric Dumazet wrote:
> Stefan Richter a écrit :
>> include/linux/skbuff.h:357:41: error: invalid bitfield specifier for
>> type restricted __be16.
...
> No problem here... how do you get this error, and what is your sparse version ?
It's sparse 0.4.2.
The note is only logged with 'make ... CF="-D__CHECK_ENDIAN__"'.
I guess sparse could be taught to ignore :_ suffixes if the suffix
covers the whole width of the type... unless there is something that
could be improved in kmemcheck.
--
Stefan Richter
-=====-==--= =-== -=-==
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-11 21:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-11 20:41 sparse noise due to patch "net: fix kmemcheck annotations" Stefan Richter
2009-11-11 21:13 ` Eric Dumazet
2009-11-11 21:42 ` Stefan Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).