From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [RFC] vlan: GRO rx statistics Date: Sat, 14 Nov 2009 08:27:29 +0100 Message-ID: <4AFE5BE1.2000909@gmail.com> References: <4AF99A50.5080301@gmail.com> <4AFD8C31.10703@gmail.com> <20091114012741.GA18764@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "David S. Miller" , Linux Netdev List To: Herbert Xu Return-path: Received: from gw1.cosmosbay.com ([212.99.114.194]:42586 "EHLO gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753444AbZKNH1c (ORCPT ); Sat, 14 Nov 2009 02:27:32 -0500 In-Reply-To: <20091114012741.GA18764@gondor.apana.org.au> Sender: netdev-owner@vger.kernel.org List-ID: Herbert Xu a =E9crit : > On Fri, Nov 13, 2009 at 05:41:21PM +0100, Eric Dumazet wrote: >> Replying to myself, I found root of the problem and posted a fix. >=20 > Just curious, do you have a link to that fix? >=20 Sure, I thought you were a netdev subscriber, sorry :) [PATCH net-next-2.6] vlan: Use __vlan_hwaccel_put_tag() in rx http://patchwork.ozlabs.org/patch/38377/ >> Still the race while updating dev->stats.tx_{bytes|packets} should b= e addressed eventually... >=20 > Well making it per-napi_struct should do the trick. >=20 > Cheers,