From: Eric Dumazet <eric.dumazet@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [RFC] vlan: GRO rx statistics
Date: Sun, 15 Nov 2009 20:35:56 +0100 [thread overview]
Message-ID: <4B00581C.3060303@gmail.com> (raw)
In-Reply-To: <20091114012741.GA18764@gondor.apana.org.au>
Herbert Xu a écrit :
> On Fri, Nov 13, 2009 at 05:41:21PM +0100, Eric Dumazet wrote:
>> Still the race while updating dev->stats.tx_{bytes|packets} should be addressed eventually...
>
> Well making it per-napi_struct should do the trick.
For normal devices, probably (but many of them use hardware counters anyway)
but not vlan :)
vlan_hwaccel_do_receive() has no napi context.
next prev parent reply other threads:[~2009-11-15 19:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 16:52 [RFC] vlan: GRO rx statistics Eric Dumazet
2009-11-13 16:41 ` Eric Dumazet
2009-11-13 16:44 ` Eric Dumazet
2009-11-14 1:27 ` Herbert Xu
2009-11-14 7:27 ` Eric Dumazet
2009-11-15 19:35 ` Eric Dumazet [this message]
2009-11-16 5:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B00581C.3060303@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).