From: Frank Blaschka <blaschka@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [patch 4/5] [PATCH] qeth: rework TSO functions
Date: Mon, 16 Nov 2009 07:58:37 +0100 [thread overview]
Message-ID: <4B00F81D.8090106@linux.vnet.ibm.com> (raw)
In-Reply-To: <20091113.203621.39740182.davem@davemloft.net>
David Miller schrieb:
> From: frank.blaschka@de.ibm.com
> Date: Thu, 12 Nov 2009 11:11:44 +0100
>
>> From: Frank Blaschka <frank.blaschka@de.ibm.com>
>>
>> The maximum TSO size OSA can handle is 15 * PAGE_SIZE. This
>> patch reduces gso_max_size to this value and adds some sanity
>> checks and statistics to the TSO implementation.
>> Since only layer 3 is able to do TSO move all TSO related functions
>> to the qeth_l3 module.
>>
>> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
>
> Please don't add sysctl knobs for getting and setting TSO enabling,
> that's what ethtool is for.
I did not add any new sysfs knobs for TSO. The old one was just moved
from the core part of the driver to the L3 discipline. I know ethtool
is the way to configure TSO and I would be happy to drop sysfs off, but
we have to keep this legacy interface because of our customers and
distributors. If you say there is no way to keep it let me know and I
will rework the patch.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-s390" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-11-16 6:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 10:11 [patch 0/5] s390: qeth patches for 2.6.33 frank.blaschka
2009-11-12 10:11 ` [patch 1/5] [PATCH] qeth: Exploit Connection Isolation frank.blaschka
2009-11-12 10:11 ` [patch 2/5] [PATCH] qeth: remaining EDDP cleanup frank.blaschka
2009-11-12 10:11 ` [patch 3/5] [PATCH] qeth: Recognize return codes of ccw_device_set_online frank.blaschka
2009-11-12 10:11 ` [patch 4/5] [PATCH] qeth: rework TSO functions frank.blaschka
2009-11-14 4:36 ` David Miller
2009-11-16 6:58 ` Frank Blaschka [this message]
2009-11-16 10:36 ` David Miller
2009-11-12 10:11 ` [patch 5/5] [PATCH] qeth: allow dynamic change of rx checksumming frank.blaschka
2009-11-16 5:23 ` [patch 0/5] s390: qeth patches for 2.6.33 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B00F81D.8090106@linux.vnet.ibm.com \
--to=blaschka@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).