Re: [net-next-2.6 PATCH v6 4/7 RFC] TCPCT part 1d: define TCP cookie option, extend existing struct's

[William Allen Simpson <william.allen.simpson@gmail.com>]

David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Mon, 16 Nov 2009 23:26:04 +0100
> 
>> So adding DATA to SYN packets might be problematic for part of our tcp stack.
> 
But is outside the scope of anything in this part 1 patch series.

Of course, part 2 will dispense with the request_sock entirely....


> I can almost guarentee it won't work.  For one thing getting a SACK
> response to a SYN+DATA packet will explode quite nicely for one thing.
> 
Sounds like a lack of error handling to me....  Never trust that sensible
data will appear from the network!


> A lot of the other retransmit queue handling would need to be audited
> as well.  So much code assumes that if we see sent data in the
> retransmit queue, there won't be SYN or SYN+ACK things in there to
> contend with.
> 
Well then, it's a darn tootin' good thing that the code in part 1g doesn't
send SYNACK data in the retransmit queue, and the code in 1d (here) doesn't
include the SYNACK data in the tcp_minisocks.c clone.  The prominent
comment might have been a sign to the careful reviewer:

+		 * as it differs for each connection.  There is no need to
+		 * copy any s_data_payload stored at the original socket.