From mboxrd@z Thu Jan 1 00:00:00 1970 From: William Allen Simpson Subject: Re: [PATCH 17/11]Optimize the upload speed for PPP connection. Date: Tue, 17 Nov 2009 06:49:20 -0500 Message-ID: <4B028DC0.2010907@gmail.com> References: <20091117111454.GA8341@ff.dom.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: huananhu@huawei.com, David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Jarek Poplawski Return-path: Received: from mail-yw0-f202.google.com ([209.85.211.202]:63582 "EHLO mail-yw0-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753709AbZKQLtT (ORCPT ); Tue, 17 Nov 2009 06:49:19 -0500 In-Reply-To: <20091117111454.GA8341@ff.dom.local> Sender: netdev-owner@vger.kernel.org List-ID: Jarek Poplawski wrote: > On 17-11-2009 11:20, William Allen Simpson wrote: >> David Miller wrote: >>> Your patch is broken, please don't wate my time like this. >>> >>> + git apply --check --whitespace=error-all diff >>> error: patch failed: drivers/net/ppp_async.c:36 >>> error: drivers/net/ppp_async.c: patch does not apply >>> >> What David may have meant, had he followed Documentation/ManagementStyle >> or had any project management skills what-so-ever, is that you need to >> follow Documentation/SubmittingPatches more carefully. > > I think this time it was only about a missing tab ;-) > In his inimitable inimical manner, comprehensively comprehensible. ;-)