From: Jarek Poplawski <jarkao2@gmail.com>
To: Tom Herbert <therbert@google.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] rps: core implementation
Date: Tue, 17 Nov 2009 22:32:02 +0100 [thread overview]
Message-ID: <4B031652.4050403@gmail.com> (raw)
In-Reply-To: <65634d660911102253o2b4f7a19kfed5849e5c88bfe1@mail.gmail.com>
Tom Herbert wrote, On 11/11/2009 07:53 AM:
> Third version of RPS.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
...
> +static int get_rps_cpu(struct net_device *dev, struct sk_buff *skb)
> +{
> + u32 addr1, addr2, ports;
> + struct ipv6hdr *ip6;
> + struct iphdr *ip;
> + u32 hash, ihl;
> + u8 ip_proto;
> + int cpu;
> + struct rps_map *map = NULL;
> +
> + if (dev->rps_num_maps) {
> + /*
> + * Locate the map corresponding to the NAPI queue that
> + * the packet was received on.
> + */
> + int index = skb_get_rx_queue(skb);
> + if (index < 0 || index >= dev->rps_num_maps)
skb_get_rx_queue() returns u16, so 'index < 0' seems wrong here.
Jarek P.
next prev parent reply other threads:[~2009-11-17 21:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 6:53 [PATCH 1/2] rps: core implementation Tom Herbert
2009-11-11 8:20 ` Eric Dumazet
2009-11-11 16:28 ` Tom Herbert
2009-11-11 21:44 ` Andi Kleen
2009-11-12 2:32 ` David Miller
2009-11-16 11:15 ` David Miller
2009-11-11 16:49 ` Randy Dunlap
2009-11-11 21:43 ` Andi Kleen
2009-11-16 17:02 ` Tom Herbert
2009-11-19 10:08 ` Andi Kleen
2009-11-20 6:41 ` Tom Herbert
2009-11-20 6:49 ` Eric Dumazet
2009-11-12 20:23 ` Eric Dumazet
2009-11-16 11:19 ` David Miller
2009-11-16 16:43 ` Tom Herbert
2009-11-18 7:21 ` David Miller
2009-11-19 8:08 ` Jarek Poplawski
2009-11-20 22:52 ` David Miller
2009-11-17 21:32 ` Jarek Poplawski [this message]
2009-11-19 9:57 ` Jarek Poplawski
2009-11-20 17:08 ` Tom Herbert
2009-11-20 19:00 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B031652.4050403@gmail.com \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).