* [PATCH] ieee802154: dont leak skbs in ieee802154_fake_xmit()
@ 2009-11-19 11:28 Eric Dumazet
2009-11-19 15:57 ` Dmitry Eremin-Solenikov
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2009-11-19 11:28 UTC (permalink / raw)
To: David S. Miller; +Cc: Dmitry Eremin-Solenikov, Linux Netdev List
ieee802154_fake_xmit() should free skbs since it returns NETDEV_TX_OK
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
diff --git a/drivers/ieee802154/fakehard.c b/drivers/ieee802154/fakehard.c
index 96a2959..7c544f7 100644
--- a/drivers/ieee802154/fakehard.c
+++ b/drivers/ieee802154/fakehard.c
@@ -260,15 +260,12 @@ static int ieee802154_fake_close(struct net_device *dev)
static netdev_tx_t ieee802154_fake_xmit(struct sk_buff *skb,
struct net_device *dev)
{
- skb->iif = dev->ifindex;
- skb->dev = dev;
dev->stats.tx_packets++;
dev->stats.tx_bytes += skb->len;
- dev->trans_start = jiffies;
-
/* FIXME: do hardware work here ... */
+ dev_kfree_skb(skb);
return NETDEV_TX_OK;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ieee802154: dont leak skbs in ieee802154_fake_xmit()
2009-11-19 11:28 [PATCH] ieee802154: dont leak skbs in ieee802154_fake_xmit() Eric Dumazet
@ 2009-11-19 15:57 ` Dmitry Eremin-Solenikov
2009-11-19 20:27 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Eremin-Solenikov @ 2009-11-19 15:57 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David S. Miller, Linux Netdev List
On Thu, Nov 19, 2009 at 2:28 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> ieee802154_fake_xmit() should free skbs since it returns NETDEV_TX_OK
Acked-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
David, please apply.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ieee802154: dont leak skbs in ieee802154_fake_xmit()
2009-11-19 15:57 ` Dmitry Eremin-Solenikov
@ 2009-11-19 20:27 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-11-19 20:27 UTC (permalink / raw)
To: dbaryshkov; +Cc: eric.dumazet, netdev
From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Date: Thu, 19 Nov 2009 18:57:48 +0300
> On Thu, Nov 19, 2009 at 2:28 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> ieee802154_fake_xmit() should free skbs since it returns NETDEV_TX_OK
>
> Acked-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
>
> David, please apply.
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-19 20:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-19 11:28 [PATCH] ieee802154: dont leak skbs in ieee802154_fake_xmit() Eric Dumazet
2009-11-19 15:57 ` Dmitry Eremin-Solenikov
2009-11-19 20:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).