* netlink: remove subscriptions check on notifier
@ 2009-11-16 22:05 Johannes Berg
2009-11-17 12:09 ` David Miller
2009-11-19 14:22 ` Patrick McHardy
0 siblings, 2 replies; 3+ messages in thread
From: Johannes Berg @ 2009-11-16 22:05 UTC (permalink / raw)
To: netdev; +Cc: Patrick McHardy
The netlink URELEASE notifier doesn't notify for
sockets that have been used to receive multicast
but it should be called for such sockets as well
since they might _also_ be used for sending and
not solely for receiving multicast. We will need
that for nl80211 (generic netlink sockets) in the
future.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Patrick McHardy <kaber@trash.net>
---
net/netlink/af_netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- wireless-testing.orig/net/netlink/af_netlink.c 2009-11-16 23:02:13.000000000 +0100
+++ wireless-testing/net/netlink/af_netlink.c 2009-11-16 23:02:23.000000000 +0100
@@ -497,7 +497,7 @@ static int netlink_release(struct socket
skb_queue_purge(&sk->sk_write_queue);
- if (nlk->pid && !nlk->subscriptions) {
+ if (nlk->pid) {
struct netlink_notify n = {
.net = sock_net(sk),
.protocol = sk->sk_protocol,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: netlink: remove subscriptions check on notifier
2009-11-16 22:05 netlink: remove subscriptions check on notifier Johannes Berg
@ 2009-11-17 12:09 ` David Miller
2009-11-19 14:22 ` Patrick McHardy
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2009-11-17 12:09 UTC (permalink / raw)
To: johannes; +Cc: netdev, kaber
From: Johannes Berg <johannes@sipsolutions.net>
Date: Mon, 16 Nov 2009 23:05:34 +0100
> The netlink URELEASE notifier doesn't notify for
> sockets that have been used to receive multicast
> but it should be called for such sockets as well
> since they might _also_ be used for sending and
> not solely for receiving multicast. We will need
> that for nl80211 (generic netlink sockets) in the
> future.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Applied, let's see what this breaks :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: netlink: remove subscriptions check on notifier
2009-11-16 22:05 netlink: remove subscriptions check on notifier Johannes Berg
2009-11-17 12:09 ` David Miller
@ 2009-11-19 14:22 ` Patrick McHardy
1 sibling, 0 replies; 3+ messages in thread
From: Patrick McHardy @ 2009-11-19 14:22 UTC (permalink / raw)
To: Johannes Berg; +Cc: netdev
Johannes Berg wrote:
> The netlink URELEASE notifier doesn't notify for
> sockets that have been used to receive multicast
> but it should be called for such sockets as well
> since they might _also_ be used for sending and
> not solely for receiving multicast. We will need
> that for nl80211 (generic netlink sockets) in the
> future.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Cc: Patrick McHardy <kaber@trash.net>
I've audited all users of this (all within netfilter) and this
change makes sense for them as well.
Acked-by: Patrick McHardy <kaber@trash.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-19 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-16 22:05 netlink: remove subscriptions check on notifier Johannes Berg
2009-11-17 12:09 ` David Miller
2009-11-19 14:22 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).