From: Patrick McHardy <kaber@trash.net>
To: "Williams, Mitch A" <mitch.a.williams@intel.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"shemminger@vyatta.com" <shemminger@vyatta.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>
Subject: Re: [RFC PATCH 1/4] net: Add support to netdev ops for changing hardware queue MAC and VLAN filters
Date: Thu, 19 Nov 2009 19:58:43 +0100 [thread overview]
Message-ID: <4B059563.3010702@trash.net> (raw)
In-Reply-To: <EA929A9653AAE14F841771FB1DE5A1365FA6A1FF82@rrsmsx501.amr.corp.intel.com>
Williams, Mitch A wrote:
> However, I'm still back to code complexity, and general usage models.
>
> Please explain specifically what you perceive to be the difference between:
>
> $ ip link set eth1 queue 1 mac <blah>
> $ ip link set eth1 queue 1 vlan <foo>
>
> and
>
> $ ip link set eth1 queue 1 mac <blah> vlan <foo>
>
> The two filter types are, in my mind, completely orthogonal. You can have one, or the other, or both, or neither. What do we gain by glomming both options on one command line? And is this worth the tradeoff of more complex code?
One argument would be that "ip link show" should probably display
all filters, so they all need to be included in the dump message.
And this is exactly the same message type used for configuring
links and the API is supposed to be symetric, meaning you can
send a dump message with NLM_F_REQUEST to the kernel again and
it (re-)creates the same object.
next prev parent reply other threads:[~2009-11-19 18:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 21:50 [RFC PATCH 1/4] net: Add support to netdev ops for changing hardware queue MAC and VLAN filters Jeff Kirsher
2009-11-17 21:50 ` [RFC PATCH 2/4] rtnetlink: Add support to rtnetlink for setting " Jeff Kirsher
2009-11-17 21:50 ` [RFC PATCH 3/4] igb: Add support to igb for setting MAC and VLAN filters to hardware queues Jeff Kirsher
2009-11-17 21:51 ` [RFC PATCH 4/4] igbvf: Make error message more enlightening Jeff Kirsher
2009-11-18 19:53 ` [RFC PATCH 1/4] net: Add support to netdev ops for changing hardware queue MAC and VLAN filters Ben Hutchings
2009-11-18 21:37 ` Williams, Mitch A
2009-11-18 23:14 ` Ben Hutchings
2009-11-18 23:33 ` Williams, Mitch A
2009-11-19 14:54 ` Ben Hutchings
2009-11-19 18:43 ` Williams, Mitch A
2009-11-19 18:58 ` Patrick McHardy [this message]
2009-11-19 19:12 ` Williams, Mitch A
2009-11-19 18:59 ` Ben Hutchings
2009-11-19 19:34 ` Williams, Mitch A
2009-11-23 13:22 ` Ben Hutchings
2009-11-23 19:52 ` Williams, Mitch A
2009-11-24 14:18 ` Ben Hutchings
2009-11-24 16:14 ` Williams, Mitch A
2009-11-30 6:03 ` Simon Horman
2009-11-30 18:36 ` Williams, Mitch A
2009-11-30 22:57 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B059563.3010702@trash.net \
--to=kaber@trash.net \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).